close
Skip to content

Add max drop level item property and remove hardcoded check from DefaultDropGenerator #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardosmaniotto wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add max drop level item property and remove hardcoded check from DefaultDropGenerator #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d676462
add max drop level item property and remove hardcoded check from Defa…
eduardosmaniotto Apr 26, 2026
489ad28
split socket items in new _droppableSocketItemsPerMonsterLevel
eduardosmaniotto Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/DataModel/Configuration/Items/ItemDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ public partial class ItemDefinition
/// </summary>
public byte DropLevel { get; set; }

/// <summary>
/// Gets or sets the maximum monster level at which this item can be dropped.
/// If no value is set, there is no upper limit.
/// </summary>
public byte? MaximumDropLevel { get; set; }

/// <summary>
/// Gets or sets the maximum item level.
/// </summary>
Expand Down Expand Up @@ -178,4 +184,4 @@ public string GetNameForLevel(byte itemLevel)

return itemName ?? string.Empty;
}
}
}
6 changes: 6 additions & 0 deletions src/DataModel/Properties/ModelResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,6 +2419,12 @@
<data name="ItemDefinition_DropLevel_Description" xml:space="preserve">
<value></value>
</data>
<data name="ItemDefinition_MaximumDropLevel_Caption" xml:space="preserve">
<value>Maximum Drop Level</value>
</data>
<data name="ItemDefinition_MaximumDropLevel_Description" xml:space="preserve">
<value></value>
</data>
<data name="ItemDefinition_MaximumItemLevel_Caption" xml:space="preserve">
<value>Maximum Item Level</value>
</data>
Expand Down
Loading