Add max drop level item property and remove hardcoded check from DefaultDropGenerator

[eduardosmaniotto]

• Created new column for item MaximumDropLevel
• Created new project for GameLogic benchmark

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a flexible mechanism to limit item drops based on monster levels by adding a 'MaximumDropLevel' property to item definitions. It cleans up the drop generation logic by removing hardcoded constraints and introduces a new benchmarking project to help monitor and optimize game logic performance.

Highlights

• Data Model Update: Added a new 'MaximumDropLevel' property to the ItemDefinition class to allow restricting item drops based on monster level.
• Game Logic Refactoring: Refactored DefaultDropGenerator to remove hardcoded checks and improve drop generation logic, including the implementation of the new maximum drop level constraint.
• Performance Benchmarking: Introduced a new project for benchmarking game logic, specifically targeting drop generation and party-related calculations.
• Database Migration: Added a new Entity Framework migration to include the MaximumDropLevel column in the database schema and updated existing configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a MaximumDropLevel property to ItemDefinition to restrict item drops based on monster level, specifically applied to the Jewel of Chaos. It includes database migrations, resource updates, and logic changes in DefaultDropGenerator to enforce this limit. Additionally, the PR refactors the drop generation logic for better readability and adds a comprehensive suite of benchmarks for DefaultDropGenerator and Party XP/money distribution. A critical issue was identified in the DefaultDropGenerator where the monster level item cache does not account for the socket item filter, potentially leading to incorrect cached results.