Replace only needed range in CodeMirror#347
Merged
Conversation
Contributor
Author
|
@yuku Please review this PR 🙏🙏 |
Owner
105ddc0 to
b4a34e7
Compare
Contributor
Author
|
@yuku Thanks for the fix Lint! I merged the changes, please run CI. 🙏 |
Owner
|
@phigasui please check the lint errors reported by CI. |
5219821 to
0ee5e68
Compare
Contributor
Author
|
@yuku I found a problem in the changes and fixed it, so please review again:pray: |
yuku
approved these changes
Sep 18, 2021
Owner
|
v0.1.10 was released |
Contributor
Author
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #346
SearchResultclass to provide replacement data.SearchResult#replace, the information needed for replacement can be obtained with getReplacementData, which is used inSearchResult#replaceand@textcomplete/codemirror.