Open
Conversation
8684563 to
895c4b3
Compare
895c4b3 to
b070c35
Compare
b070c35 to
ddbbc93
Compare
ddbbc93 to
038317b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 038317b. Configure here.
038317b to
3ebb823
Compare
3ebb823 to
9fed2de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #11763
Adds a
@only-named-argumentsdocblock annotation that requires callers to use named arguments. This is useful for libraries that want to enforce named-argument call sites as part of their BC policy — allowing parameter reordering or removal without breaking positional callers.When a positional argument is passed to a function or method annotated with
@only-named-arguments, Psalm emits the newPositionalArgumentNotAllowedissue. Spread/unpack calls are also covered:foo(...[0, 1])triggers the issue whilefoo(...['a' => 0, 'b' => 1])is allowed.Using both
@only-named-argumentsand@no-named-argumentson the same declaration is flagged asInvalidDocblock.For variadic parameters, the inferred type of
...$argsbecomesarray<string, T>(instead oflist<T>with@no-named-argumentsorarray<array-key, T>without annotation).@only-named-argumentstakes priority over the globalallowInternalNamedArgumentCalls="false"andallowNamedArgumentCalls="false"config options, allowing library authors to selectively enforce named arguments on specific APIs even in codebases that otherwise disable named argument calls.