fix: Reorder extension resolution to prioritise TypeScript over JSON#1315
Open
PierreVanobbergen wants to merge 1 commit intovercel:mainfrom
Open
fix: Reorder extension resolution to prioritise TypeScript over JSON#1315PierreVanobbergen wants to merge 1 commit intovercel:mainfrom
PierreVanobbergen wants to merge 1 commit intovercel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory contains both
test.jsonandtest.ts, an extensionless import like:resolves to
test.jsoninstead oftest.ts, causing all exported methods from the TypeScript file to be unresolvable during the build.Webpack resolves extensions in the order they appear in the
resolve.extensionsarray.Since
.jsonappears before.tsand.tsx, webpack picks the JSON file first when both exist.Reproduce
(The test project need a
tsconfig.jsonwithcompilerOptions.resolveJsonModule: true)Create a directory with two files sharing the same base name:
src/test.json{ "key": "value" }src/test.tsImport without an extension from another TypeScript file:
src/index.tsRun
ncc build src/index.tsthe build fails because./testresolves totest.json, which has nogreetexport.