close
Skip to content

[7.2] Show Docker container MAC addresses#2624

Merged
limetech merged 1 commit into7.2from
codex/7.2-docker-mac-display
Apr 24, 2026
Merged

[7.2] Show Docker container MAC addresses#2624
limetech merged 1 commit into7.2from
codex/7.2-docker-mac-display

Conversation

@elibosley
Copy link
Copy Markdown
Member

Summary

  • Backports the Docker container MAC address display fix from master to 7.2.
  • Passes endpoint MAC addresses through the Docker client/container data path and renders them with the existing container IP details.
  • Keeps MAC display hidden when no running container endpoint value exists.

Why

The 7.2 Docker container list did not expose assigned MAC addresses, making it hard to confirm fixed or runtime endpoint MACs from the UI.

Validation

  • php -l emhttp/plugins/dynamix.docker.manager/include/DockerClient.php
  • php -l emhttp/plugins/dynamix.docker.manager/include/DockerContainers.php
  • git diff --check origin/7.2..HEAD

- Purpose: backport the Docker MAC address display fix from master to 7.2.

- Before: the Docker container list only showed IP details, so assigned MAC addresses were not visible in the UI.

- Problem: users could not confirm fixed or runtime MAC assignments from the container list.

- Change: include MAC address data from Docker inspect output and render it with the container IP details.

- Implementation: pass endpoint MAC addresses through DockerClient and DockerContainers, then hide empty values for stopped containers.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e0cb9e7d-04c1-4b81-bcaf-7e1f3668453f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/7.2-docker-mac-display

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.23.2102
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2624/webgui-pr-2624.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.docker.manager/DockerContainers.page
emhttp/plugins/dynamix.docker.manager/include/DockerClient.php
emhttp/plugins/dynamix.docker.manager/include/DockerContainers.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2624, or run:

plugin remove webgui-pr-2624

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley elibosley added the 7.2 label Apr 23, 2026
@elibosley elibosley marked this pull request as ready for review April 24, 2026 15:38
@limetech limetech merged commit 2927fb0 into 7.2 Apr 24, 2026
2 checks passed
@limetech limetech deleted the codex/7.2-docker-mac-display branch April 24, 2026 19:06
@github-actions
Copy link
Copy Markdown

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.


🤖 This comment is automatically generated when a PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants