[7.2] Show Docker container MAC addresses#2624
Conversation
- Purpose: backport the Docker MAC address display fix from master to 7.2. - Before: the Docker container list only showed IP details, so assigned MAC addresses were not visible in the UI. - Problem: users could not confirm fixed or runtime MAC assignments from the container list. - Change: include MAC address data from Docker inspect output and render it with the container IP details. - Implementation: pass endpoint MAC addresses through DockerClient and DockerContainers, then hide empty values for stopped containers.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
🧹 PR Test Plugin Cleaned UpThe test plugin and associated files for this PR have been removed from the preview environment. 🤖 This comment is automatically generated when a PR is closed. |
Summary
Why
The 7.2 Docker container list did not expose assigned MAC addresses, making it hard to confirm fixed or runtime endpoint MACs from the UI.
Validation
php -l emhttp/plugins/dynamix.docker.manager/include/DockerClient.phpphp -l emhttp/plugins/dynamix.docker.manager/include/DockerContainers.phpgit diff --check origin/7.2..HEAD