[codex] Normalize offline/online spelling in array copy#2622
[codex] Normalize offline/online spelling in array copy#2622
Conversation
- Purpose: normalize user-facing status copy from "off-line" to "offline" across the web UI. - Before: the array stop helper text, offline usage-bar state, and device status label used the hyphenated spelling "off-line". - Problem: the wording was inconsistent with the rest of the UI and read like a typo in the affected screens. - Change: replace those strings with "offline" in the three affected views/helpers. - How: update the static copy in ArrayOperation, the offline usage-bar fallback in Helpers, and the stopped-array status text in nchan/update_2.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThree UI-facing files standardize wording by replacing "off-line" with "offline" in array operation messages, filesystem usage display, and device status output. No logic, control flow, or exported declarations were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
- Purpose: normalize remaining array state helper copy from "on-line" to "online". - Before: ArrayOperation start-state helper text used the hyphenated form "on-line" across multiple stopped-array paths. - Problem: the wording was inconsistent with the rest of the UI and did not match the earlier offline normalization. - Change: replace all user-facing "on-line" strings in ArrayOperation with "online". - How: update the start-action helper text for configuration-valid, parity-check, disk-clear, rebuild, and related array start states.
What changed
off-linewithofflinein the array stop helper textoff-linewithofflinein the offline usage-bar fallbackoff-linewithofflinein the stopped-array device status labelon-linewithonlinein the array start helper text across the stopped-array flowsWhy
A handful of older UI strings were still using hyphenated
off-lineandon-linespellings, which made the copy look inconsistent and dated next to the rest of the product.Impact
Users will now see normalized
offlineandonlinewording in the affected array status and action helper text.Root cause
These older status strings had not been normalized when the rest of the interface copy moved to
offlineandonline.Validation
php -l emhttp/plugins/dynamix/ArrayOperation.pagephp -l emhttp/plugins/dynamix/include/Helpers.phpphp -l emhttp/plugins/dynamix/nchan/update_2git diff --checkSummary by CodeRabbit