close
Skip to content

[codex] Normalize offline/online spelling in array copy#2622

Draft
elibosley wants to merge 6 commits intomasterfrom
codex/offline-copy-fix
Draft

[codex] Normalize offline/online spelling in array copy#2622
elibosley wants to merge 6 commits intomasterfrom
codex/offline-copy-fix

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented Apr 23, 2026

What changed

  • replace off-line with offline in the array stop helper text
  • replace off-line with offline in the offline usage-bar fallback
  • replace off-line with offline in the stopped-array device status label
  • replace on-line with online in the array start helper text across the stopped-array flows

Why

A handful of older UI strings were still using hyphenated off-line and on-line spellings, which made the copy look inconsistent and dated next to the rest of the product.

Impact

Users will now see normalized offline and online wording in the affected array status and action helper text.

Root cause

These older status strings had not been normalized when the rest of the interface copy moved to offline and online.

Validation

  • php -l emhttp/plugins/dynamix/ArrayOperation.page
  • php -l emhttp/plugins/dynamix/include/Helpers.php
  • php -l emhttp/plugins/dynamix/nchan/update_2
  • git diff --check

Summary by CodeRabbit

  • Style
    • Standardized status labels across the UI: changed "off-line" → "offline" and "on-line" → "online" for disk and filesystem states, confirmation messages, and start/recovery flows to ensure consistent terminology and presentation.

- Purpose: normalize user-facing status copy from "off-line" to "offline" across the web UI.
- Before: the array stop helper text, offline usage-bar state, and device status label used the hyphenated spelling "off-line".
- Problem: the wording was inconsistent with the rest of the UI and read like a typo in the affected screens.
- Change: replace those strings with "offline" in the three affected views/helpers.
- How: update the static copy in ArrayOperation, the offline usage-bar fallback in Helpers, and the stopped-array status text in nchan/update_2.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 156c0105-d22f-4ae8-8ac1-b9eb061cfa98

📥 Commits

Reviewing files that changed from the base of the PR and between 6064124 and ab5e8d8.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/ArrayOperation.page
✅ Files skipped from review due to trivial changes (1)
  • emhttp/plugins/dynamix/ArrayOperation.page

Walkthrough

Three UI-facing files standardize wording by replacing "off-line" with "offline" in array operation messages, filesystem usage display, and device status output. No logic, control flow, or exported declarations were changed.

Changes

Cohort / File(s) Summary
Terminology Standardization
emhttp/plugins/dynamix/ArrayOperation.page, emhttp/plugins/dynamix/include/Helpers.php, emhttp/plugins/dynamix/nchan/update_2
Replaced occurrences of the user-facing label "off-line" with "offline" in array stop confirmations, filesystem usage text, and disk device status output. No functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I nibble at a hyphen tonight,

off-line shrinks to offline light,
A tiny hop, a tidy fix,
The UI hums with cleaner ticks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: normalizing offline/online spelling across array operation UI strings in three files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/offline-copy-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@elibosley elibosley changed the title [codex] Replace off-line with offline feat: Replace off-line with offline Apr 23, 2026
@elibosley elibosley added the 7.3 label Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.23.1458
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2622/webgui-pr-2622.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/ArrayOperation.page
emhttp/plugins/dynamix/include/Helpers.php
emhttp/plugins/dynamix/nchan/update_2

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2622, or run:

plugin remove webgui-pr-2622

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley elibosley requested a review from limetech April 23, 2026 13:42
- Purpose: normalize remaining array state helper copy from "on-line" to "online".
- Before: ArrayOperation start-state helper text used the hyphenated form "on-line" across multiple stopped-array paths.
- Problem: the wording was inconsistent with the rest of the UI and did not match the earlier offline normalization.
- Change: replace all user-facing "on-line" strings in ArrayOperation with "online".
- How: update the start-action helper text for configuration-valid, parity-check, disk-clear, rebuild, and related array start states.
@elibosley elibosley changed the title feat: Replace off-line with offline [codex] Normalize offline/online spelling in array copy Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant