close
Skip to content

SAA docs tweaks#4482

Open
dandavison wants to merge 2 commits intomainfrom
dan/saa-tweaks
Open

SAA docs tweaks#4482
dandavison wants to merge 2 commits intomainfrom
dan/saa-tweaks

Conversation

@dandavison
Copy link
Copy Markdown
Contributor

@dandavison dandavison commented Apr 23, 2026

What does this PR do?

Make Go and .NET code work when followed naively from the docs.

┆Attachments: EDU-6260 SAA docs tweaks

/tmp/dotnet-logger-repro/Worker cat Program.cs
using Microsoft.Extensions.Logging;
using Temporalio.Client;
using Temporalio.Common.EnvConfig;
using Temporalio.Worker;

var connectOptions = ClientEnvConfig.LoadClientConnectOptions();
connectOptions.TargetHost ??= "localhost:7233";
connectOptions.LoggerFactory = LoggerFactory.Create(builder =>
    builder.
        AddSimpleConsole(options => options.TimestampFormat = "[HH:mm:ss] ").
        SetMinimumLevel(LogLevel.Information));
var client = await TemporalClient.ConnectAsync(connectOptions);
/tmp/dotnet-logger-repro/Worker dotnet build
MSBuild version 17.8.49+7806cbf7b for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
/private/tmp/dotnet-logger-repro/Worker/Program.cs(8,32): error CS0103: The name 'LoggerFactory' does not exist in the current context [/private/tmp/dotnet-logger-repro/Worker/Worker.csproj]

Build FAILED.

/private/tmp/dotnet-logger-repro/Worker/Program.cs(8,32): error CS0103: The name 'LoggerFactory' does not exist in the current context [/private/tmp/dotnet-logger-repro/Worker/Worker.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.64
@dandavison dandavison requested a review from a team as a code owner April 23, 2026 21:10
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview, Comment Apr 23, 2026 9:10pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

connectOptions.LoggerFactory = LoggerFactory.Create(builder =>
builder.
AddSimpleConsole(options => options.TimestampFormat = "[HH:mm:ss] ").
SetMinimumLevel(LogLevel.Information));
Copy link
Copy Markdown
Contributor Author

@dandavison dandavison Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tmp/dotnet-logger-repro/Worker cat Program.cs
using Microsoft.Extensions.Logging;
using Temporalio.Client;
using Temporalio.Common.EnvConfig;
using Temporalio.Worker;

var connectOptions = ClientEnvConfig.LoadClientConnectOptions();
connectOptions.TargetHost ??= "localhost:7233";
connectOptions.LoggerFactory = LoggerFactory.Create(builder =>
    builder.
        AddSimpleConsole(options => options.TimestampFormat = "[HH:mm:ss] ").
        SetMinimumLevel(LogLevel.Information));
var client = await TemporalClient.ConnectAsync(connectOptions);


/tmp/dotnet-logger-repro/Worker dotnet build
MSBuild version 17.8.49+7806cbf7b for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
/private/tmp/dotnet-logger-repro/Worker/Program.cs(8,32): error CS0103: The name 'LoggerFactory' does not exist in the current context [/private/tmp/dotnet-logger-repro/Worker/Worker.csproj]

Build FAILED.

/private/tmp/dotnet-logger-repro/Worker/Program.cs(8,32): error CS0103: The name 'LoggerFactory' does not exist in the current context [/private/tmp/dotnet-logger-repro/Worker/Worker.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.64

```go
handle := c.GetActivityHandle(client.GetActivityHandleOptions{
ActivityID: "my-standalone-activity-id",
ActivityID: "standalone_activity_helloworld_ActivityID",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse activityID from earlier in the page so the code works if they've run the code above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant