close
Skip to content

Upgrade Apache NMS packages #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Jul 23, 2025
Merged

Upgrade Apache NMS packages #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Apache.NMS" Version="2.0.0" />
<PackageVersion Include="Apache.NMS.ActiveMQ" Version="1.7.2" />
<PackageVersion Include="Apache.NMS" Version="2.2.0" />
<PackageVersion Include="Apache.NMS.ActiveMQ" Version="2.1.1" />
<PackageVersion Include="log4net" Version="3.0.4" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Log4Net.AspNetCore" Version="8.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Antlr3.Runtime" Version="3.5.1" />
<PackageVersion Include="Apache.NMS" Version="2.0.0" />
<PackageVersion Include="Apache.NMS" Version="2.2.0" />
<PackageVersion Include="Castle.NVelocity" Version="1.1.1" />
<PackageVersion Include="Common.Logging" Version="3.4.1" />
<PackageVersion Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0.1" />
Expand Down
19 changes: 11 additions & 8 deletions src/Spring/Spring.Messaging.Nms/Messaging/Nms/Connections/CachedMessageConsumer .cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,17 @@ public string MessageSelector
/// </summary>
public event MessageListener Listener
{
add
{
target.Listener += value;
}
remove
{
target.Listener -= value;
}
add => target.Listener += value;
remove => target.Listener -= value;
}

/// <summary>
/// An asynchronous listener which can be used to consume messages asynchronously.
/// </summary>
public event AsyncMessageListener AsyncListener
{
add => target.AsyncListener += value;
remove => target.AsyncListener -= value;
}

/// <summary>
Expand Down
6 changes: 6 additions & 0 deletions src/Spring/Spring.Messaging.Nms/Messaging/Nms/Connections/NmsConsumer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,10 @@ public event MessageListener Listener
add => consumer.Listener += value;
remove => consumer.Listener -= value;
}

public event AsyncMessageListener AsyncListener
{
add => consumer.AsyncListener += value;
remove => consumer.AsyncListener -= value;
}
}
4 changes: 2 additions & 2 deletions test/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Apache.NMS" Version="2.0.0" />
<PackageVersion Include="Apache.NMS.ActiveMQ" Version="1.7.2" />
<PackageVersion Include="Apache.NMS" Version="2.2.0" />
<PackageVersion Include="Apache.NMS.ActiveMQ" Version="2.1.1" />
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
<PackageVersion Include="FakeItEasy" Version="8.3.0" />
<PackageVersion Include="FakeItEasy.Analyzer.CSharp" Version="6.1.1" />
Expand Down
7 changes: 7 additions & 0 deletions test/Spring/Spring.Messaging.Nms.Tests/Messaging/Nms/Connections/TestMessageConsumer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,20 @@ public class TestMessageConsumer : IMessageConsumer
{
public string MessageSelector { get; }
public event MessageListener Listener;
public event AsyncMessageListener AsyncListener;

private void InvokeListener(IMessage message)
{
MessageListener listener = Listener;
if (listener != null) listener(message);
}

private void InvokeAsyncListener(IMessage message)
{
AsyncMessageListener listener = AsyncListener;
if (listener != null) listener(message, CancellationToken.None);
}

public IMessage Receive()
{
throw new NotImplementedException();
Expand Down
6 changes: 6 additions & 0 deletions ...ring/Spring.Messaging.Nms.Tests/Messaging/Nms/Core/SimpleMessageListenerContainerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,18 @@ internal class SimpleMessageConsumer : IMessageConsumer
{
public string MessageSelector { get; }
public event MessageListener Listener;
public event AsyncMessageListener AsyncListener;

public void SendMessage(IMessage message)
{
Listener(message);
}

public void SendAsyncMessage(IMessage message)
{
AsyncListener(message, CancellationToken.None);
}

public IMessage Receive()
{
throw new NotImplementedException();
Expand Down