Open
Conversation
Author
|
ABCL fails the last test because it does not implement proper quoting of the arguments that it passes to shell (but it is not external-program's job to do that when its interface requires no escaping on the callers part). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was astonished to find out that external-program does not support passing environment variables under SBCL as provided by the user, adding single quotes around them instead.
This is an attempt to improve handling of environment variables.
PATH=toenv -iis wrong; empty environment is not the one withPATHdefined to be an empty string. Yes, this allows some programs to run without full path, because asman 3 execsays, for the purpose ofexecundefined PATH defaults toconfstr(_CS_PATH)(in C) orgetconf CS_PATH(in shell), and on my system, for example, that evaluates to/bin:/usr/bin.should-have-access-to-shell-builtins— why? Running programs under shell is difficult to get right specifically because of quoting, and provides no benefits over running them directly (unless the user wants shell features, but external-program does not really facilitate that).empty-env-should-erase-all— yes, butlsmay succeed even with empty environment.I tested the change under SBCL, CCL, CLISP and ECL.