close
Skip to content

media: imx708: Support configuring continuous clock from DT #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
6by9 wants to merge 1 commit into
base: rpi-6.18.y
Choose a base branch
from
+17 −0
Draft

media: imx708: Support configuring continuous clock from DT #7329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions drivers/media/i2c/imx708.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ MODULE_PARM_DESC(qbc_adjust, "Quad Bayer broken line correction strength [0,2-5]
#define IMX708_REG_MID_ANALOG_GAIN 0x3118
#define IMX708_REG_SHT_ANALOG_GAIN 0x0216

#define IMX708_REG_CLKLANE_BLANK 0x3220
#define IMX708_CLKLANE_BLANK_NONCONT BIT(0)

/* QBC Re-mosaic broken line correction registers */
#define IMX708_LPF_INTENSITY_EN 0xC428
#define IMX708_LPF_INTENSITY_ENABLED 0x00
Expand Down Expand Up @@ -866,6 +869,8 @@ struct imx708 {
unsigned int long_exp_shift;

unsigned int link_freq_idx;

unsigned int csi_flags;
};

static inline struct imx708 *to_imx708(struct v4l2_subdev *_sd)
Expand Down Expand Up @@ -1499,6 +1504,16 @@ static int imx708_start_streaming(struct imx708 *imx708)
return ret;
}

ret = imx708_write_reg(imx708, IMX708_REG_CLKLANE_BLANK,
IMX708_REG_VALUE_08BIT,
imx708->csi_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ?
IMX708_CLKLANE_BLANK_NONCONT : 0);
if (ret) {
dev_err(&client->dev, "%s failed to set clock lane mode\n",
__func__);
return ret;
}

ret = imx708_read_reg(imx708, IMX708_REG_BASE_SPC_GAINS_L,
IMX708_REG_VALUE_08BIT, &val);
if (ret == 0 && val == 0x40) {
Expand Down Expand Up @@ -1972,6 +1987,8 @@ static int imx708_check_hwcfg(struct device *dev, struct imx708 *imx708)
goto error_out;
}

imx708->csi_flags = ep_cfg.bus.mipi_csi2.flags;

ret = 0;

error_out:
Expand Down
Loading