Improve error message for scope#1176
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 46 46
Lines 2655 2656 +1
=======================================
+ Hits 2447 2448 +1
Misses 208 208 ☔ View full report in Codecov by Sentry. |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
lorenzwalthert
left a comment
There was a problem hiding this comment.
Thanks, just minor changes...
|
Thanks for your suggestion, I applied them + a couple extra things here and there!
|
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
IndrajeetPatil
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @olivroy!
I think this can be merged once Lorenz also green-lights it.
Also fixing some errors I introduced. When linking only to a help page, one should use topic, not help.
Also, I was wondering if it was possible to run styler, but only for quotes, i.e. changing
''to""?