close
Skip to content

Improve error message for scope#1176

Merged
IndrajeetPatil merged 8 commits intor-lib:mainfrom
olivroy:scope
Feb 2, 2024
Merged

Improve error message for scope#1176
IndrajeetPatil merged 8 commits intor-lib:mainfrom
olivroy:scope

Conversation

@olivroy
Copy link
Copy Markdown
Contributor

@olivroy olivroy commented Jan 31, 2024

Also fixing some errors I introduced. When linking only to a help page, one should use topic, not help.

Also, I was wondering if it was possible to run styler, but only for quotes, i.e. changing '' to ""?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dbaa169) 92.16% compared to head (c315cf0) 92.16%.

❗ Current head c315cf0 differs from pull request most recent head 4b999fb. Consider uploading reports for the commit 4b999fb to get more accurate results

Files Patch % Lines
R/parse.R 0.00% 4 Missing ⚠️
R/addins.R 80.00% 1 Missing ⚠️
R/transform-code.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1176   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          46       46           
  Lines        2655     2656    +1     
=======================================
+ Hits         2447     2448    +1     
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:

  •   :ballot_box_with_check:cache_applying: 166ms -> 169ms [-1.33%, +4.24%]
  •   :ballot_box_with_check:cache_recording: 556ms -> 558ms [-0.63%, +1.22%]
  •   :ballot_box_with_check:without_cache: 1.05s -> 1.05s [-0.65%, +0.72%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Comment thread R/style-guides.R Outdated
Comment thread R/transform-code.R Outdated
Copy link
Copy Markdown
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just minor changes...

Comment thread R/addins.R Outdated
@olivroy
Copy link
Copy Markdown
Contributor Author

olivroy commented Feb 1, 2024

Thanks for your suggestion, I applied them + a couple extra things here and there!

  • arg_match0() for performance, change link in package doc and inherit package doc title from DESCRIPTION. + add qmd in alpha order where applicable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:

  •   :ballot_box_with_check:cache_applying: 139ms -> 137ms [-3.45%, +0.56%]
  •   :ballot_box_with_check:cache_recording: 498ms -> 499ms [-0.48%, +0.86%]
  •   :ballot_box_with_check:without_cache: 966ms -> 962ms [-0.89%, +0.22%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Copy Markdown
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @olivroy!

I think this can be merged once Lorenz also green-lights it.

Copy link
Copy Markdown
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @olivroy. You can merge.

@IndrajeetPatil IndrajeetPatil merged commit 775c399 into r-lib:main Feb 2, 2024
@olivroy olivroy deleted the scope branch February 2, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants