bpo-46407: Optimizing some modulo operations by thatbirdguythatuknownot · Pull Request #30653 · python/cpython

thatbirdguythatuknownot · 2022-01-17T23:09:40Z

https://bugs.python.org/issue46407

sweeneyde · 2022-01-17T23:43:02Z

long_mod could probably use this too.

thatbirdguythatuknownot · 2022-01-18T00:07:57Z

long_mod could probably use this too.

Done.

sweeneyde · 2022-01-18T21:49:59Z

I did some pyperf benchmarking on a variety of input sizes:

https://gist.github.com/sweeneyde/c13681e7c2c2f086b9082b3e4cfd8137

Up to 1.46x faster, no worse than 1.09x slower. Using --min-speed=3 (3%), 15 cases were slower, 111 cases were faster. Geometric mean across all benchmarks was 1.06x faster.

Executables were compiled with --enable-optimizations --with-lto on GCC on WSL.

Retain fast path

Fix documentation for l_mod and remove recently added branch.

Fix documentation

Fix conflicts

thatbirdguythatuknownot · 2022-01-23T20:49:49Z

It seems that PR has lost all activity save for recent fix of conflict.

thatbirdguythatuknownot · 2022-01-25T01:44:24Z

PR bump.

tim-one

Left some notes about comments that appear to need repairing. Other than those, looks good!

bedevere-bot · 2022-01-25T02:17:37Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot · 2022-01-25T02:59:09Z

Thanks for making the requested changes!

@tim-one: please review the changes made to this pull request.

bedevere-bot · 2022-01-25T04:15:50Z

Thanks for making the requested changes!

@tim-one: please review the changes made to this pull request.

tim-one

Thanks! I'm out of complaints 😄.

thatbirdguythatuknownot · 2022-01-26T22:02:34Z

PR bump.

thatbirdguythatuknownot · 2022-01-27T22:44:25Z

PR bump 2.

tim-one

I don't see your name (assuming it's Jeremiah Vivian) in Misc/ACKS. It's not mandatory that you add it there, but it is traditional. If you'd like to add it there, this would be the time to do it.

thatbirdguythatuknownot · 2022-01-27T22:56:42Z

Alright.

bedevere-bot · 2022-01-27T23:02:11Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot · 2022-01-27T23:26:29Z

Thanks for making the requested changes!

@tim-one: please review the changes made to this pull request.

bpo-46407: Optimizing some modulo operations

d3d0b45

the-knights-who-say-ni added the CLA signed label Jan 17, 2022

bedevere-bot added the awaiting review label Jan 17, 2022

📜🤖 Added by blurb_it.

39b9c09

sweeneyde reviewed Jan 17, 2022

View reviewed changes

Comment thread Objects/longobject.c

bpo-46407: Optimizing some modulo operations

cf1ac24

sweeneyde requested a review from mdickinson January 17, 2022 23:52

bpo-46407: Optimizing some modulo operations

ad71a1c

thatbirdguythatuknownot added 3 commits January 19, 2022 06:29

bpo-46407: Optimizing some modulo operations

9e9fd00

Retain fast path

Update 2022-01-17-23-12-01.bpo-46407.2_5a7R.rst

fd48510

bpo-46407: Optimizing some modulo operations

99ac778

Fix documentation for l_mod and remove recently added branch.

cfbolz reviewed Jan 19, 2022

View reviewed changes

Comment thread Objects/longobject.c Outdated

thatbirdguythatuknownot added 2 commits January 20, 2022 05:16

bpo-46407: Optimizing some modulo operations

80a2d27

Fix documentation

bpo-46407: Optimizing some modulo operations

ca6bb8e

Fix conflicts

thatbirdguythatuknownot added 2 commits January 24, 2022 05:27

bpo-46407: Optimizing some modulo operations

6566099

bpo-46407: Optimizing some modulo operations

6598819

sweeneyde requested a review from tim-one January 25, 2022 01:46

tim-one requested changes Jan 25, 2022

View reviewed changes

Comment thread Objects/longobject.c Outdated

Comment thread Objects/longobject.c

Comment thread Objects/longobject.c Outdated

bedevere-bot removed the awaiting review label Jan 25, 2022

bedevere-bot added the awaiting changes label Jan 25, 2022

bpo-46407: Optimizing some modulo operations

a66085f

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 25, 2022

bpo-46407: Optimizing some modulo operations

bea9bde

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 25, 2022

bedevere-bot requested a review from tim-one January 25, 2022 04:15

tim-one approved these changes Jan 25, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 25, 2022

sweeneyde reviewed Jan 25, 2022

View reviewed changes

Comment thread Objects/longobject.c Outdated

bpo-46407: Optimizing some modulo operations

3d01b63

tim-one reviewed Jan 27, 2022

View reviewed changes

Update ACKS

7da4d33

tim-one requested changes Jan 27, 2022

View reviewed changes

Comment thread Misc/ACKS Outdated

bedevere-bot added awaiting changes and removed awaiting merge labels Jan 27, 2022

Update ACKS

1c897fc

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 27, 2022

bedevere-bot requested a review from tim-one January 27, 2022 23:26

tim-one approved these changes Jan 28, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 28, 2022

tim-one merged commit f10dafc into python:main Jan 28, 2022

bedevere-bot removed the awaiting merge label Jan 28, 2022

Uh oh!

Conversation

thatbirdguythatuknownot commented Jan 17, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sweeneyde commented Jan 17, 2022

Uh oh!

thatbirdguythatuknownot commented Jan 18, 2022

Uh oh!

sweeneyde commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

thatbirdguythatuknownot commented Jan 23, 2022

Uh oh!

thatbirdguythatuknownot commented Jan 25, 2022

Uh oh!

tim-one left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 25, 2022

Uh oh!

bedevere-bot commented Jan 25, 2022

Uh oh!

bedevere-bot commented Jan 25, 2022

Uh oh!

tim-one left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thatbirdguythatuknownot commented Jan 26, 2022

Uh oh!

thatbirdguythatuknownot commented Jan 27, 2022

Uh oh!

tim-one left a comment

Choose a reason for hiding this comment

Uh oh!

thatbirdguythatuknownot commented Jan 27, 2022

Uh oh!

Uh oh!

bedevere-bot commented Jan 27, 2022

Uh oh!

bedevere-bot commented Jan 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thatbirdguythatuknownot commented Jan 17, 2022 •

edited by bedevere-bot

Loading

sweeneyde commented Jan 18, 2022 •

edited

Loading