Metrics: Record incoming request sizes by guscarreon · Pull Request #4495 · prebid/prebid-server

guscarreon · 2025-08-20T16:10:07Z

Adds a metric to keep track of the size in bytes of requests that hit the /auction, /amp and /video endpoints. Should we add the cookie_sync endpoint?

Prometheus

To anyone who reviews, please let me know if you agree with the buckets (1000, 5000, 10000, 15000, 20000, 40000, 75000, and 100000 bytes respectively)

  pbs_sub_request_queue_time_bucket{request_status="requestRejectedLabel",request_type="video",le="240"} 0
  pbs_sub_request_queue_time_bucket{request_status="requestRejectedLabel",request_type="video",le="300"} 0
  pbs_sub_request_queue_time_bucket{request_status="requestRejectedLabel",request_type="video",le="+Inf"} 0
  pbs_sub_request_queue_time_sum{request_status="requestRejectedLabel",request_type="video"} 0
  pbs_sub_request_queue_time_count{request_status="requestRejectedLabel",request_type="video"} 0
+ # HELP pbs_sub_request_size_bytes Count that keeps track of incoming request size in bytes labeled by endpoint.
+ # TYPE pbs_sub_request_size_bytes histogram
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="1000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="5000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="10000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="15000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="20000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="40000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="75000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="100000"} 1
+ pbs_sub_request_size_bytes_bucket{request_endpoint="auction",le="+Inf"} 1
+ pbs_sub_request_size_bytes_sum{request_endpoint="auction"} 809
+ pbs_sub_request_size_bytes_count{request_endpoint="auction"} 1
  # HELP pbs_sub_request_time_seconds Seconds to resolve successful Prebid Server requests labeled by type.
  # TYPE pbs_sub_request_time_seconds histogram
  pbs_sub_request_time_seconds_bucket{request_type="amp",le="0.05"} 0
  pbs_sub_request_time_seconds_bucket{request_type="amp",le="0.1"} 0

bsardo

I don't think we need the metric for any other endpoints. Auction, amp and video endpoints are sufficient.

bsardo · 2025-08-21T23:49:06Z

 	priceBuckets := []float64{250, 500, 750, 1000, 1500, 2000, 2500, 3000, 3500, 4000}
 	queuedRequestTimeBuckets := []float64{0, 1, 5, 30, 60, 120, 180, 240, 300}
 	overheadTimeBuckets := []float64{0.05, 0.06, 0.07, 0.08, 0.09, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1}
+	requestSizeBuckets := []float64{1000, 5000, 10000, 15000, 20000, 40000, 75000, 100000}


How were these buckets chosen? Are they based off of any real requests? Have we seen at least one request that falls into each of these buckets or at least most of them?

This is difficult to say... My test request that invokes a lot of request-related features (Stored bid responses, FPD, multi-type imp, category mapping, etc) takes ~4500 bytes.
Should we first see how production data will look like and adjust buckets accordingly?

How were these buckets chosen?

Arbitrarily. These have to be discussed and carefully chosen first.

VeronikaSolovei9 · 2025-08-22T04:43:47Z

+	endpoint := metrics.GetEndpointFromRequestType(labels.RType)
+	m.requestsSize.With(prometheus.Labels{
+		requestEndpointLabel: string(endpoint),
+	}).Observe(float64(labels.RequestSize))
+


I tested this PR with AMP endpoint and found that if stored request was not found and request Len was never measured, we still write 0 bytes to metrics.
It falls into the very first basket and looks like this in result:

# TYPE pbs_sub_request_size_bytes histogram pbs_sub_request_size_bytes_bucket{request_size="amp",le="1000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="5000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="10000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="15000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="20000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="40000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="75000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="100000"} 1 pbs_sub_request_size_bytes_bucket{request_size="amp",le="+Inf"} 1

It can be misinterpreted that request had less than 1000 bytes, where in fact that was an error.
Should we add the check for the labels.RequestStatus? Only write metric if labels.RequestStatus == metrics.RequestStatusOK?

I tested this PR with AMP endpoint and found that if stored request was not found and request Len was never measured, we still write 0 bytes to metrics.

Really? Let me go in there with the debugger. Do you mind sharing the amp request you used for this test?

Doesn't the AMP endpoint need to be updated to set this label in loadRequestJSONForAmp? I don't think we are recording the size on this endpoint at the moment.

Doesn't the AMP endpoint need to be updated

Yes. Corrected

SyntaxNode · 2025-09-04T06:28:47Z

 	priceBuckets := []float64{250, 500, 750, 1000, 1500, 2000, 2500, 3000, 3500, 4000}
 	queuedRequestTimeBuckets := []float64{0, 1, 5, 30, 60, 120, 180, 240, 300}
 	overheadTimeBuckets := []float64{0.05, 0.06, 0.07, 0.08, 0.09, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1}
+	requestSizeBuckets := []float64{600, 700, 800, 900, 1000, 1500, 3000, 5000, 6000, 7500, 10000, 15000}


This bucket range allows for a max request size of ~15kb. I think that's too small. I've seen very large requests in the wild, especially when privacy signals are involved. Everyone's mileage will vary, but how about we start with 100kb as a max size?

Something like...
requestSizeBuckets := []float64{100, 500, 1000, 2000, 5000, 10000, 20000, 50000, 75000, 100000}

Discussed offline.
requestSizeBuckets := []float64{100, 500, 750, 1000, 2000, 4000, 7000, 10000, 15000, 20000, 50000, 75000}

Corrected. New buckets:

pbs_sub_request_queue_time_sum{request_status="requestRejectedLabel",request_type="video"} 0 pbs_sub_request_queue_time_count{request_status="requestRejectedLabel",request_type="video"} 0 + # HELP pbs_sub_request_size_bytes Count that keeps track of incoming request size in bytes labeled by endpoint. + # TYPE pbs_sub_request_size_bytes histogram + pbs_sub_request_size_bytes_bucket{request_size="auction",le="100"} 0 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="500"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="750"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="1000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="2000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="4000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="7000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="10000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="15000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="20000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="50000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="75000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="auction",le="+Inf"} 1 + pbs_sub_request_size_bytes_sum{request_size="auction"} 217 + pbs_sub_request_size_bytes_count{request_size="auction"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="100"} 0 + pbs_sub_request_size_bytes_bucket{request_size="video",le="500"} 0 + pbs_sub_request_size_bytes_bucket{request_size="video",le="750"} 0 + pbs_sub_request_size_bytes_bucket{request_size="video",le="1000"} 0 + pbs_sub_request_size_bytes_bucket{request_size="video",le="2000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="4000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="7000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="10000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="15000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="20000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="50000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="75000"} 1 + pbs_sub_request_size_bytes_bucket{request_size="video",le="+Inf"} 1 + pbs_sub_request_size_bytes_sum{request_size="video"} 1790 + pbs_sub_request_size_bytes_count{request_size="video"} 1 # HELP pbs_sub_request_time_seconds Seconds to resolve successful Prebid Server requests labeled by type. # TYPE pbs_sub_request_time_seconds histogram pbs_sub_request_time_seconds_bucket{request_type="amp",le="0.05"} 0

bsardo · 2025-09-04T14:51:52Z

 		errs = []error{err}
 		return
 	}
+	labels.RequestSize = len(requestJson)


It looks like we are capturing the size of the request that comes in over the wire prior to merging in stored requests for both the auction and video endpoints while the amp endpoint captures the request size after stored requests are merged. IMO this is a bit confusing. Do we even need the amp request size since it is just based on stored requests?

Modified to not log these metrics oh the amp endpoint

linux019 · 2025-09-05T06:21:07Z

 	priceBuckets := []float64{250, 500, 750, 1000, 1500, 2000, 2500, 3000, 3500, 4000}
 	queuedRequestTimeBuckets := []float64{0, 1, 5, 30, 60, 120, 180, 240, 300}
 	overheadTimeBuckets := []float64{0.05, 0.06, 0.07, 0.08, 0.09, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1}
+	requestSizeBuckets := []float64{100, 500, 750, 1000, 2000, 4000, 7000, 10000, 15000, 20000, 50000, 75000}


This looks to pretty hardcoded sizes
I would use max_request_size / 10 buckets
https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#LinearBuckets

@gravelg

* Dianomi: Update user syncs to send gdpr_consent (prebid#4345) * MobileFuse: Remove tagid_src and pub_id params (prebid#4303) * Remove tagid_src ext from MobileFuse Adapter * remove pub_id query param * removed comment * Simplify Endpoint assignment in MobileFuseAdapter * New Adapter: Flatads (prebid#4243) Co-authored-by: wuzhijian <wuch1k1n@qq.com> * Rubicon: Add bid meta seat (prebid#4348) * Gothamads: Add Intenze alias (prebid#4319) * GumGum: Collect ad unit name for reporting (prebid#4302) * Seedtag: Fix required content-type header on http calls (prebid#4299) * Kobler: Remove sensitive device and user data (prebid#4295) * New Adapter: Nexx360 (prebid#4286) Co-authored-by: Gabriel Chicoye <gabriel@macbookrogab24g.lan> * HTTP Fetcher: Implement RFC 3986 compatibility as optional (prebid#4272) * Targeting: Add configurable targeting prefix (prebid#4355) * Pubmatic: Set bid.meta.mediaType=video when bid.ext.ibv=true (prebid#4189) * Rules Engine Module: Phase 1 (prebid#4407) Co-authored-by: Veronika Solovei <kalypsonika@gmail.com> Co-authored-by: guscarreon <guscarreon@gmail.com> * New Adapter: Sparteo (prebid#4275) * PubMatic: Fix missing bid type in bid response (prebid#4417) * Fix: Remove module per request JSON marshal and add custom viper decoder (prebid#4422) * RichAudience: change endpoint to https (prebid#4384) Co-authored-by: IAN <ian.musachs@exte.com> * Missena: Pass full openrtb request (prebid#4394) * New Adapter: Rediads (prebid#4233) * Zeta Global SSP: Declare OpenRTB 2.6 and GPP support (prebid#4389) * Record metric unsuccessful for PBC non-200 response status code or error (prebid#4341) Co-authored-by: oleksandr <oleksandr@assertive.ai> * New Adapter: Akcelo (prebid#4237) * New Adapter: Zentotem (prebid#4053) * New Adapter: Exco (prebid#4250) * Floors: Fix panic while getting adunit code for signaling (prebid#4424) * Stroeercore: Add adomain to bids (prebid#4392) * VIS.X: Relay bid currency from bid response (prebid#4381) * TMax: Add default host config (prebid#4430) * Fix the package (iterators) to agree with the dir (iterutil). (prebid#4447) * TheTradeDesk: Throw error for malformed endpoint url (prebid#4419) * Smartadserver : Send multi-impression requests without flattening (prebid#4402) Co-authored-by: nlesommer <nlesommer@equativ.com> Co-authored-by: gtodeschi <gregoire.todeschi@gmail.com> * RTB House: Remove PAAPI signals from imp[].ext (prebid#4399) * GumGum: Enable Opt-In change notification (prebid#4390) * Tappx: Add GPID support (prebid#4438) Co-authored-by: Jordi Arnau <jarnau@tappx.com> * New Adapter: progx - Vidazoo alias (prebid#4428) * New Adapter: Kuantyx - Aso alias (prebid#4420) * MinuteMedia: Add test endpoint (prebid#4425) * Adagio: Add site bidder param and web inventory tests (prebid#4403) Co-authored-by: Godefroi Roussel <groussel@adagio.io> * Modularity: Add hook code to module invocation context (prebid#4036) * Rubicon: Pass ext.prebid.multibid[].maxbids to XAPI (prebid#4412) * OpenX: Add gpp params to user sync (prebid#4445) Co-authored-by: gmiedlar-ox <gabriela.miedlar@openx.com> * New Adapter: Blis (prebid#4304) Co-authored-by: Tomas Koutny <tomas@blis.com> * Ogury: Support gpp for cookie sync (prebid#4406) * TheTradeDesk: Resolve AUCTION_PRICE macro (prebid#4448) * Fix: Set account http fetcher defaults enabling env vars (prebid#4460) * Bidder throttling code to increase network stability. (prebid#4415) * Adding request throttling to bidder requests * Add latency health * Adds new config options, metrics, and fixes * Set default window to 1000 and fix error type typo * Addresses PR comments * More PR feedback * Proper handling of the atomic uint in tests * Yieldlab: Forward ADomain to OpenRTB bid (prebid#4404) * Yandex: Add video support (prebid#4344) * Request: Add hb_env=amp targeting to AMP responses (prebid#4414) * Pubmatic: Forward skadn object in bid request (prebid#4453) * Adds missing defaults to network throttling code (prebid#4477) * New Adapter: Tagoras - Vidazoo alias (prebid#4329) Co-authored-by: anna-y-perion <annay@perion.com> * New Adapter: Omnidex - Vidazoo alias (prebid#4441) * Define An Adapter As White Label Only (prebid#4461) * Rules Engine Module: Result functions fix (prebid#4451) * Account: Support bid rounding options (prebid#4470) * Sovrn: Fix passing through imp.ext.gpid (prebid#4413) * Smartadserver: Add second endpoint for programmatic guaranteed (prebid#4467) Co-authored-by: Guillaume Laubier <glaubier@equativ.com> * sspBC: Updates moving operations to backend service (prebid#4351) * New Adapter: Adipolo - Xeworks alias (prebid#4350) Co-authored-by: And-Rud <andrii@xe.works> Co-authored-by: rbstdev <devgit204@xe.works> * Modules: Exitpoint Stage (prebid#4435) * New Adapter: Afront (prebid#4380) * Harden HTTP Response Body Handling (prebid#4489) * New Adapter: TeqBlaze (prebid#4480) * Onetag: imp.ext read generalization (prebid#4446) Co-authored-by: lorenzob <l.baglini@onetag.com> * Rules Engine Module: Configurable cache update frequency (prebid#4423) Co-authored-by: VeronikaSolovei9 <vsolovei@microsoft.com> * New Adapter: RocketLab (prebid#4383) * change zmaticoo.yaml endpoint (prebid#4471) Co-authored-by: Quentin.zuo <quentin.zuo@eclicktech.com.cn> * Metrics: Record GVL fetch count (prebid#4500) * TheTradeDesk: Resolve burl if not resolved (prebid#4481) * New Adapter: pinkLion (prebid#4376) * Metrics: Record HTTP connections wanted and obtained (prebid#4518) * Metrics: Record incoming request sizes (prebid#4495) * Modules: Execute mutations in the order they are listed (prebid#4279) * 4278 Execute mutations in the sequence they are listed. * Ensure that the rejected channel is closed (once) on reject * Use stack var. * Add comments. * Ensure rejected is closed. * Just return explicitly in all 3 cases. * Keep the same style - of passing the params to the go routine. * Revert "Modules: Execute mutations in the order they are listed (prebid#4279)" (prebid#4529) This reverts commit 93c17c2. * Revert "Metrics: Record HTTP connections wanted and obtained (prebid#4518)" (prebid#4538) * New Adapter: Nativery (prebid#4321) Co-authored-by: Andrea Fassina <fasenderos@gmail.com> Co-authored-by: nicoladellamorte <nicola.dellamorte@nativery.com> * E-Planning: Add support for adomain (prebid#4472) * SmileWanted: Append zoneId to endpoint path (prebid#4468) Co-authored-by: QuentinGallard <quentin.gallard@digitalnolimit.com> * Add configurable dialer timeouts to HTTP clients (prebid#4511) * New Adapter: 360playvid (prebid#4395) * New Adapter: MediaYo (prebid#4391) * 33across: Make zoneId the preferred option (prebid#4531) * 33across: Remove deprecated video.placement (prebid#4530) * New Adapter: RobustApps - Xeworks alias (prebid#4434) Co-authored-by: And-Rud <andrii@xe.works> Co-authored-by: rbstdev <devgit204@xe.works> * Adagio: Remove max length on params (prebid#4524) Co-authored-by: Godefroi Roussel <groussel@adagio.io> * fwssp: Add iframe usersync (prebid#4487) Co-authored-by: wenyuanzhang <wenyuanzhang@freewheel.tv> * Module: Scope3 Real-Time Data (prebid#4397) * Add Scope3 Real-Time Data (RTD) module This module integrates Scope3's Real-Time Data API to provide audience segments for targeting in Prebid Server auctions. Features: - Fetches real-time audience segments from Scope3 API - Adds targeting data to bid requests via hooks system - Thread-safe segment storage during auction lifecycle - Configurable timeout and endpoint settings - Graceful error handling that doesn't fail auctions The module implements three hook stages: - Entrypoint: Initialize module context - Raw Auction Request: Fetch segments from Scope3 API - Processed Auction Request: Add segments to targeting data 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add LiveRamp ATS integration and execution order documentation - Document proper execution order when using with LiveRamp ATS - Add user identifier detection for RampID integration - Include configuration examples for sequential module execution - Enhance API requests with available user identifiers - Add comprehensive documentation for Yahoo deployment scenario 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add LiveRamp ATS envelope support for publishers without sidecar - Support forwarding encrypted ATS envelopes directly to Scope3 API - Check multiple envelope locations: user.ext.liveramp_idl, user.ext.ats_envelope, ext.liveramp_idl - Prioritize sidecar RampID over envelope when both available - Document both sidecar and envelope integration patterns - Add note about Scope3 needing LiveRamp partner authorization This enables publishers without LiveRamp sidecar to still benefit from LiveRamp ATS user signals via encrypted envelope forwarding. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Clean up debug code and finalize production-ready Scope3 RTD module - Remove all debug logging statements - Streamline segment storage and retrieval between hooks - Finalize request-level targeting for GAM integration - Production-ready code with proper error handling - Complete documentation with configuration examples The module is now ready for production deployment with: - Successful Scope3 API integration - LiveRamp ATS compatibility (sidecar and envelope) - GAM targeting data output - Thread-safe segment management 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Simplify targeting output to single GAM-compatible format - Remove duplicate data.scope3_segments array format - Keep only targeting.hb_scope3_segments as comma-separated string - Follows standard header bidding targeting key conventions - Optimized for GAM key-value targeting integration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add unit tests for Scope3 RTD module - Add basic unit tests for module builder and hook functions - Test invalid config handling and error cases - Test entrypoint hook initialization - Test processed auction hook with no segments - Satisfy CI requirements for test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix Go formatting issues - Remove trailing whitespace in module.go - Add missing newline at end of module_test.go - Satisfy gofmt validation requirements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Address PR feedback: Add caching, improve LiveRamp integration, enhance configurability Key improvements based on reviewer feedback: - Add intelligent caching with configurable TTL to handle repeated requests - Set 60-second default cache TTL for frequency cap compatibility - Improve LiveRamp identifier detection across multiple locations - Remove unsubstantiated partnership claims and improve documentation - Add cache_ttl_seconds and bid_meta_data configuration options - Implement MD5-based cache keys from user IDs and site context - Add comprehensive test coverage for new caching functionality - Update documentation to explain targeting vs bid.meta approach - Change default timeout to 1000ms for better API compatibility Addresses concerns about: - Performance with hundreds of identical requests per user session - Flexibility in targeting data output (bid.meta future enhancement noted) - Accurate LiveRamp integration documentation - Proper hook implementation code naming 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Complete PR feedback implementation: Response-level segments with GAM targeting Major changes to address all PR reviewer feedback: **Response Format Changes:** - Move from request targeting to auction response data per reviewer feedback - Change hook stage from processed_auction_request to auction_response - Add segments to response.ext.scope3.segments for publisher control - Add individual GAM targeting keys when add_to_targeting=true (e.g., gmp_eligible=true) **Configuration Updates:** - Rename bid_meta_data to add_to_targeting for clarity - Add comprehensive GAM integration with individual segment keys - Remove incorrect LiveRamp RTD adapter references from README - Update hook configuration examples to use auction_response stage **API Integration Fixes:** - Correct segment parsing to exclude destination field (triplelift.com) - Extract only actual segments from imp[].ext.scope3.segments[] - Maintain working authentication and caching functionality **Enhanced Testing:** - Add comprehensive mock API integration tests - Test both response formats (scope3 + targeting sections) - Test error handling with mock server responses - Apply gofmt formatting to all code **Publisher Benefits:** - Full control over segment usage via response.ext.scope3.segments - Optional automated GAM integration via individual targeting keys - Flexible configuration for different use cases - Maintains caching for high-frequency scenarios Addresses all PR reviewer concerns while providing maximum publisher flexibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Address PR feedback: Add optimized HTTP Transport for high-frequency API calls Per reviewer feedback (@gravelg): 'if we're going to be make a lot of calls, we should use a Transport with better defaults' - MaxIdleConns: 100 (increased connection pool) - MaxIdleConnsPerHost: 10 (multiple connections per host) - IdleConnTimeout: 90s (longer connection reuse) - ForceAttemptHTTP2: true (HTTP/2 for better performance) - DisableCompression: false (bandwidth optimization) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * run gofmt * update default endpoint * fix test * address comments * more review comments * address more comments * remove unused enhanceRequestWithUserIDs method * jsonutil, add more tests * Add privacy field masking for Scope3 RTD module Implement comprehensive privacy protection by masking sensitive user data before sending bid requests to the Scope3 API while preserving essential targeting capabilities. Features: - Configurable field masking with privacy-first defaults - Geographic data truncation with configurable precision (default: 2 decimals ~1.1km) - Identity provider filtering with allowlist for preserved EIDs - Always removes: IP addresses, user IDs, demographics, first-party data - Always preserves: device characteristics, country/region, site/app context - Comprehensive test coverage (92.3%) with edge case handling - All linting checks pass with zero issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix cache key generation for proper per-user caching - Use SHA-256 hashed user.id as fallback when privacy-safe identifiers are unavailable - Maintains per-user cache segmentation for performance while protecting privacy - Privacy-safe identifiers (RampID, LiverampIDL) take priority over hashed user.id - Prevents accidental data leakage by returning nil on masking failures - Add configuration validation for geo precision (max 4 decimal places) - Add comprehensive tests for cache key behavior and configuration validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix gofmt formatting in module_test.go 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * review fixes * more review comments * make it async * address more comments --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Gabriel Gravel <ggravel@scope3.com> * Metrics: Add connection dial metrics by adapter (prebid#4528) * KueezRTB: Remove additionalProperties from schema (prebid#4490) * Kargo: Add email to codepath notification workflow (prebid#4484) Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com> * New Adapter: Contxtful (prebid#4443) Co-authored-by: rufiange <sebastien@rufiange.com> * Modules: Exitpoint Hook typo fix (prebid#4542) * Consumable: Declare geoscope (prebid#4496) * Connatix: Copy entire imp[i].ext (prebid#4521) * Fix: Preload Prometheus adapter connection dial metric labels when enabled (prebid#4543) Co-authored-by: oleksandr <oleksandr@assertive.ai> * Host Option To Use OS Certs (prebid#4536) * CPMStar: imp.ext passthrough (prebid#4450) * MetaX: Add redirect user sync (prebid#4550) Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com> * New Adapter: Xapads - AdKernel alias (prebid#4534) * Connatix: Add GPP macros (prebid#4525) * OpenX: Return buyer exts in response (prebid#4507) Co-authored-by: Rafal Sieczka <rafal.sieczka@openx.com> * Yandex: Set referer and target-ref to site.page (prebid#4488) * Nextmillennium: New fields and adapter version update (prebid#4486) * Accounts: Add coop cookiesync priority groups (prebid#4561) * Mobkoi: Remove url endpoint override (prebid#4555) * GDPR: Move enforcement processing upstream (prebid#4567) * Actions: Add publish to docker hub workflow (prebid#4558) * Omnidex: Add GVL ID (prebid#4568) * Adagio: Fix typo (prebid#4570) * Improve Digital: Switch to HTTPS (prebid#4559) * Mobkoi: Update endpoint (prebid#4523) * Remove flaky agma test (prebid#4578) * New Adapter: appStockSSP (prebid#4502) Co-authored-by: Kanceliarenko <kostiantyn.k@teqblaze.com> * Rules Engine Module: Dynamic ruleset from YAML geoscopes (prebid#4509) * In order to protect users of prebid-server that don't use CGO, add build flag (prebid#4058) * In order to protect users of prebid-server that don't use CGO, add build flag. * Conditionally configure fiftyonedegrees. * Because the module file is auto-generated, let it include fiftyonedegrees but just explain that it can't be enabled. * include used packages. * fix builder. * Remove unused file. * Add a test for the Builder when CGO is not enabled. * New Adapter: Gravite (prebid#4547) * New Adapter: Goldbach (prebid#4476) * New Adapter: Showheroes (prebid#4533) * New Adapter: Performist - Limelight Alias (prebid#4283) * Connatix: Support GZIP (prebid#4575) * RTBHouse: PMP removal, publisherId parameter extraction (prebid#4564) * Adnuntius: Pass targeting to ad server (prebid#4545) * New Adapter: Boldwin Rapid (prebid#4478) * Scope3: Various fixes to RTD module (prebid#4544) * PubMatic: Pass alias bidder name through (prebid#4588) * BidTheatre: Update endpoint and add redirect user sync (prebid#4562) * CWire: Add userSync (prebid#4516) * New Adapter: Clydo (prebid#4535) * New Adapter: Microsoft (msft) (prebid#4592) * Syncer: Allow Duplicate Syncer Key For Identical Config (prebid#4622) * Adagio: Enable site capability (prebid#4590) * Adagio: Remove hardcoded seat name (prebid#4596) * Warn in auction response for bidders blocked by privacy settings (prebid#4537) Co-authored-by: oleksandr <oleksandr@assertive.ai> * Logging: Add interface with default glog implementation (prebid#4085) Co-authored-by: postindustria-code <oss@postindustria.com> * msp 25-12 --------- Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com> Co-authored-by: Michael Stevens <michael.stevens@dianomi.com> Co-authored-by: tomaszbmf <142428312+tomaszbmf@users.noreply.github.com> Co-authored-by: FlatAds <83808812+flatads@users.noreply.github.com> Co-authored-by: wuzhijian <wuch1k1n@qq.com> Co-authored-by: Anton Babak <76536883+AntoxaAntoxic@users.noreply.github.com> Co-authored-by: support-gotham-ads <support@gothamads.com> Co-authored-by: ShayanK16GumGum <shayan.khan@ic.gumgum.com> Co-authored-by: sangarbe <sangarbe@gmail.com> Co-authored-by: Tommy Pettersen <42890605+TommyHPettersen@users.noreply.github.com> Co-authored-by: Gabriel Chicoye <gabriel.chicoye@gmail.com> Co-authored-by: Gabriel Chicoye <gabriel@macbookrogab24g.lan> Co-authored-by: Sigma Software <prebid.opensource@sigma.software> Co-authored-by: pm-priyanka-bagade <156899734+pm-priyanka-bagade@users.noreply.github.com> Co-authored-by: Brian Sardo <1168933+bsardo@users.noreply.github.com> Co-authored-by: Veronika Solovei <kalypsonika@gmail.com> Co-authored-by: guscarreon <guscarreon@gmail.com> Co-authored-by: t-sormonte <t.sormonte@sparteo.com> Co-authored-by: Isha Bharti <isha.bharti@pubmatic.com> Co-authored-by: Rich Audience <sergi.gimenez@richaudience.com> Co-authored-by: IAN <ian.musachs@exte.com> Co-authored-by: Jean-Sébastien Ney <jeansebastien.ney@gmail.com> Co-authored-by: rediads <123890182+rediads@users.noreply.github.com> Co-authored-by: abermanov-zeta <95416296+abermanov-zeta@users.noreply.github.com> Co-authored-by: linux019 <anode.dev@gmail.com> Co-authored-by: oleksandr <oleksandr@assertive.ai> Co-authored-by: Roger <104763658+rogerDyl@users.noreply.github.com> Co-authored-by: zentotem <programmatic@zentotem.net> Co-authored-by: Pete <petropo@ex.co> Co-authored-by: Nikhil Vaidya <102963966+pm-nikhil-vaidya@users.noreply.github.com> Co-authored-by: Philip Watson <philip.watson@adscale.co.nz> Co-authored-by: Vladimir Fedoseev <vl.fedoseev@gmail.com> Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com> Co-authored-by: andre-gielow-ttd <124626380+andre-gielow-ttd@users.noreply.github.com> Co-authored-by: Nathan Le Sommer <lesommer.nathan@gmail.com> Co-authored-by: nlesommer <nlesommer@equativ.com> Co-authored-by: gtodeschi <gregoire.todeschi@gmail.com> Co-authored-by: Piotr Jaworski <109736938+piotrj-rtbh@users.noreply.github.com> Co-authored-by: sindhuja-sridharan <148382298+sindhuja-sridharan@users.noreply.github.com> Co-authored-by: jordi-tappx <jarnau@techsoulogy.com> Co-authored-by: Jordi Arnau <jarnau@tappx.com> Co-authored-by: Anna Yablonsky <annay@perion.com> Co-authored-by: Adserver.Online <61009237+adserver-online@users.noreply.github.com> Co-authored-by: inna <innayare@gmail.com> Co-authored-by: GodefroiRoussel <GodefroiRoussel@users.noreply.github.com> Co-authored-by: Godefroi Roussel <groussel@adagio.io> Co-authored-by: Kacper Fus <kacper.fus@openx.com> Co-authored-by: gmiedlar-ox <gabriela.miedlar@openx.com> Co-authored-by: tomaskoutny-blis <60094686+tomaskoutny-blis@users.noreply.github.com> Co-authored-by: Tomas Koutny <tomas@blis.com> Co-authored-by: Vincent Bachelier <vincent@ogury.co> Co-authored-by: hhhjort <31041505+hhhjort@users.noreply.github.com> Co-authored-by: yuu.t <tongyu24@hotmail.com> Co-authored-by: Dmitry Ermakov <skfyann@gmail.com> Co-authored-by: Saar Amrani <saar120@gmail.com> Co-authored-by: Scott Kay <noreply@syntaxnode.com> Co-authored-by: Sandy Janicki <sejanick@users.noreply.github.com> Co-authored-by: Guillaume Laubier <guillaume.laubier@hotmail.fr> Co-authored-by: Guillaume Laubier <glaubier@equativ.com> Co-authored-by: mabielinski-wpm <155963187+mabielinski-wpm@users.noreply.github.com> Co-authored-by: Andrii Rudyk <96918101+And-Rud@users.noreply.github.com> Co-authored-by: And-Rud <andrii@xe.works> Co-authored-by: rbstdev <devgit204@xe.works> Co-authored-by: Afrontio <support@afront.io> Co-authored-by: MaksymTeqBlaze <maksym.pavliv@teqblaze.com> Co-authored-by: esimonelli@onetag <136568337+EmanueleSimonelli@users.noreply.github.com> Co-authored-by: lorenzob <l.baglini@onetag.com> Co-authored-by: VeronikaSolovei9 <vsolovei@microsoft.com> Co-authored-by: Leandro Marty <leandro.marty@rocketlab.ai> Co-authored-by: g-coder-baiai <77920802+g-coder-baiai@users.noreply.github.com> Co-authored-by: Quentin.zuo <quentin.zuo@eclicktech.com.cn> Co-authored-by: prebidPinkLion <prebid@pinklion.io> Co-authored-by: andreafassina <127768714+andreafassina@users.noreply.github.com> Co-authored-by: Andrea Fassina <fasenderos@gmail.com> Co-authored-by: nicoladellamorte <nicola.dellamorte@nativery.com> Co-authored-by: Agustin Insua <Nistenf@users.noreply.github.com> Co-authored-by: Quentin Gallard <QuentinGallard@users.noreply.github.com> Co-authored-by: QuentinGallard <quentin.gallard@digitalnolimit.com> Co-authored-by: pb360playvid <prebid@360playvid.com> Co-authored-by: mediayo <yehuda@mediayo.co> Co-authored-by: Carlos Felix <carloshto@gmail.com> Co-authored-by: rbstdev <devgit204@gmail.com> Co-authored-by: Wenyuan Zhang <wzhang910@cable.comcast.com> Co-authored-by: wenyuanzhang <wenyuanzhang@freewheel.tv> Co-authored-by: Brian O'Kelley <bokelley@scope3.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Gabriel Gravel <ggravel@scope3.com> Co-authored-by: Amit Biton <56631148+amitbiton01@users.noreply.github.com> Co-authored-by: Shane Lacey <shanel262@hotmail.com> Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com> Co-authored-by: Sebastien Boisvert <sebastien.boisvert@contxtful.com> Co-authored-by: rufiange <sebastien@rufiange.com> Co-authored-by: richardngo-consumable <rngo@consumable.com> Co-authored-by: Karim Mourra <karim@jwplayer.com> Co-authored-by: Joshua Tomlinson <og.ginger@gmail.com> Co-authored-by: metax-kehan <115962296+metax-kehan@users.noreply.github.com> Co-authored-by: Denis Logachov <ckbo3hrk@gmail.com> Co-authored-by: Rafal Sieczka <rafal.sieczka@openx.com> Co-authored-by: Dmitry Ermakov <dimurer@yandex-team.ru> Co-authored-by: a.popov <60257866+allar15@users.noreply.github.com> Co-authored-by: Marc-Enzo Bonnafon <marcenzo.bonnafon@gmail.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com> Co-authored-by: Appstock LTD <sdksupport@app-stock.com> Co-authored-by: Kanceliarenko <kostiantyn.k@teqblaze.com> Co-authored-by: teqblaze <162988436+teqblaze@users.noreply.github.com> Co-authored-by: Simon Aebli <simon.aebli@goldbach.com> Co-authored-by: Filip Stamenkovic <ficadub@gmail.com> Co-authored-by: quietPusher <129727954+quietPusher@users.noreply.github.com> Co-authored-by: Mikael Lundin <mikael-lundin@users.noreply.github.com> Co-authored-by: BoldwinDev <sdk@bold-win.com> Co-authored-by: Gabriel Gravel <gravelg@users.noreply.github.com> Co-authored-by: Pubmatic-Supriya-Patil <131644110+Pubmatic-Supriya-Patil@users.noreply.github.com> Co-authored-by: andreasgreen <andreas.green@gmail.com> Co-authored-by: Alessandro Rosetti <alessandro.rosetti@gmail.com> Co-authored-by: cto-clydo <cto@clydo.io> Co-authored-by: Eugene Dorfman <eugene.dorfman@gmail.com> Co-authored-by: postindustria-code <oss@postindustria.com>

guscarreon added 8 commits August 19, 2025 13:40

step out quick

3fbc9f2

Merge branch 'master' into reqSizeMetric

9be1ec7

Moved GetEdnpoint() func

1444d13

rolled back metric name change

2ce92ba

Registry

3859047

VerifyMetric fix

b19d133

GetEndpointFromRequestType(requestType RequestType) test

eb2fea3

change 'endpoint' for 'size'

2fad1f9

guscarreon changed the title ~~Metric to account for request size~~ Metric for incoming request sizes Aug 20, 2025

bsardo assigned bsardo, hhhjort and VeronikaSolovei9 Aug 21, 2025

Merge branch 'master' into reqSizeMetric

5ed5714

bsardo reviewed Aug 21, 2025

View reviewed changes

VeronikaSolovei9 reviewed Aug 22, 2025

View reviewed changes

guscarreon added 5 commits August 22, 2025 16:20

Video and Amp

8e58660

remove aux files

1346ecf

New buckets

f1cd323

zero check

a85f7ac

Bucket size correction

4ffc915

VeronikaSolovei9 previously approved these changes Aug 25, 2025

View reviewed changes

SyntaxNode reviewed Sep 4, 2025

View reviewed changes

bsardo reviewed Sep 4, 2025

View reviewed changes

modify request size buckets

536f955

guscarreon dismissed VeronikaSolovei9’s stale review via 536f955 September 4, 2025 18:16

guscarreon added 2 commits September 4, 2025 14:23

Merge branch 'master' into reqSizeMetric

49f8105

removed metric for AMP endpoint

c87bd88

bsardo approved these changes Sep 4, 2025

View reviewed changes

bsardo changed the title ~~Metric for incoming request sizes~~ Metrics: Record incoming request sizes Sep 4, 2025

VeronikaSolovei9 approved these changes Sep 4, 2025

View reviewed changes

bsardo merged commit f63f77a into master Sep 4, 2025
4 checks passed

cross-repo-issue-creation Bot mentioned this pull request Sep 4, 2025

Port PR from PBS-Go: Metrics: Record incoming request sizes prebid/prebid-server-java#4177

Closed

linux019 reviewed Sep 5, 2025

View reviewed changes

danielbaud pushed a commit to alliance-gravity/prebid-server-go that referenced this pull request Nov 25, 2025

Metrics: Record incoming request sizes (prebid#4495)

15b78b6

prnvgupta pushed a commit to automatad/prebid-server that referenced this pull request Dec 3, 2025

Metrics: Record incoming request sizes (prebid#4495)

4bb8981

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Dec 15, 2025

Metrics: Record incoming request sizes (prebid#4495)

060dd43

Conversation

guscarreon commented Aug 20, 2025

Prometheus

Uh oh!

bsardo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bsardo Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bsardo Sep 4, 2025 •

edited

Loading