Return array from fast_page.to_a#6
Merged
mscoutermarsh merged 1 commit intoplanetscale:mainfrom Dec 19, 2022
Merged
Conversation
The load method returns the ActiveRecord relation rather than the Array of records that has been loaded. As to_a dups and returns records it would also return the ActiveRecord relation rather than an Array.
03a5033 to
7aafaf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load method returns the
ActiveRecordrelation rather than theArrayof records that has been loaded.As
to_adups and returnsrecordsit would also return theActiveRecordrelation rather than anArray.