close
Skip to content

[Fix] Add full registries to avoid warning#1849

Merged
ly015 merged 1 commit intoopen-mmlab:dev-1.xfrom
ly015:fix-registry
Dec 1, 2022
Merged

[Fix] Add full registries to avoid warning#1849
ly015 merged 1 commit intoopen-mmlab:dev-1.xfrom
ly015:fix-registry

Conversation

@ly015
Copy link
Copy Markdown
Member

@ly015 ly015 commented Dec 1, 2022

Motivation

Add full registry definitions in MMPose (even those with no mmpose module registered) to avoid disturbing warning information (as reported in #1699 and #1819)

Modification

  • mmpose/registry.py

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 merged commit 92d5a5b into open-mmlab:dev-1.x Dec 1, 2022
@ly015 ly015 deleted the fix-registry branch December 1, 2022 06:26
ly015 added a commit to ly015/mmpose that referenced this pull request Feb 21, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants