close
Skip to content

[Fix] Upgrade the versions of pre-commit-hooks#1705

Merged
ly015 merged 1 commit intoopen-mmlab:dev-1.xfrom
Ben-Louis:1.x-upgrade-pre-commit-hooks
Oct 8, 2022
Merged

[Fix] Upgrade the versions of pre-commit-hooks#1705
ly015 merged 1 commit intoopen-mmlab:dev-1.xfrom
Ben-Louis:1.x-upgrade-pre-commit-hooks

Conversation

@Ben-Louis
Copy link
Copy Markdown
Collaborator

Motivation

The motivation to upgrade some versions of pre-commit hooks to latest is that importlib-metadata v5.0.0 which removed deprecated endpoint breaks the flake8

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2022

Codecov Report

Base: 77.74% // Head: 77.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bb19810) compared to base (d507fb1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1705   +/-   ##
========================================
  Coverage    77.74%   77.75%           
========================================
  Files          204      204           
  Lines        11715    11715           
  Branches      1955     1955           
========================================
+ Hits          9108     9109    +1     
+ Misses        2212     2207    -5     
- Partials       395      399    +4     
Flag Coverage Δ
unittests 77.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/transforms/common_transforms.py 82.62% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis requested a review from ly015 October 8, 2022 04:28
@ly015 ly015 merged commit 3fa3b2c into open-mmlab:dev-1.x Oct 8, 2022
@Ben-Louis Ben-Louis deleted the 1.x-upgrade-pre-commit-hooks branch October 9, 2022 08:10
ly015 pushed a commit that referenced this pull request Oct 14, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants