close
Skip to content

[Refactor] Modify some scripts to fit MultilevelPixelData#1647

Merged
ly015 merged 9 commits intoopen-mmlab:dev-1.xfrom
liqikai9:cpm-mspn
Sep 16, 2022
Merged

[Refactor] Modify some scripts to fit MultilevelPixelData#1647
ly015 merged 9 commits intoopen-mmlab:dev-1.xfrom
liqikai9:cpm-mspn

Conversation

@liqikai9
Copy link
Copy Markdown
Collaborator

@liqikai9 liqikai9 commented Sep 8, 2022

Motivation

  1. Unify the multiscale, multi-scale, multi-level to multilevel; add multilevel_gt_fields in PoseDataSample;
  2. Modify MSPNHead to fit MultilevelPixelData;
  3. Fix some bugs in MultilevelPixelData add unittests for MultilevelPixelData;
  4. Modify the MSPNd and RSN configs according to the above modificatios.

All unitetsts passed locally.
The test accuracy for configs/body_2d_keypoint/topdown_heatmap/coco/td-hm_2xmspn50_8xb32-210e_coco-256x192.py is verified, will also verify other modified configs.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9 liqikai9 requested a review from ly015 September 8, 2022 08:55
Comment thread mmpose/datasets/transforms/formatting.py Outdated
Comment thread mmpose/datasets/transforms/formatting.py Outdated
@ly015
Copy link
Copy Markdown
Member

ly015 commented Sep 14, 2022

Please rebase onto the latest dev-1.x branch and fix conflicts. Also please check it can pass all unit tests.

@liqikai9
Copy link
Copy Markdown
Collaborator Author

Please rebase onto the latest dev-1.x branch and fix conflicts. Also please check it can pass all unit tests.

Done.

@ly015 ly015 merged commit 1250fe6 into open-mmlab:dev-1.x Sep 16, 2022
@liqikai9 liqikai9 deleted the cpm-mspn branch September 18, 2022 08:01
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants