Conversation
9cff8ad to
55cfd5d
Compare
richfitz
reviewed
Apr 16, 2024
| elif src.is_dir(): | ||
| shutil.copytree(src, dst, dirs_exist_ok=True) | ||
| copied = { | ||
| os.path.join(here, f): os.path.join(there, f) |
Member
There was a problem hiding this comment.
Are we not moving to pathlib everywhere? Also happy to sort this out later in a single push too
Member
Author
There was a problem hiding this comment.
This is the dictionary that ends up being returned to the caller / used in the packet metadata. I think keeping them as str is more appropriate. Path isn't json-serializable natively, so we would have to cast it back as str anyway.
This is equivalent to orderly2's orderly_shared_resource. It looks for files in the `shared` directory, at the root of the repository. Files and directories are copied to the packet directory, and recorded in the metadata.
richfitz
approved these changes
Apr 24, 2024
| # | ||
| # See https://github.com/python/cpython/issues/44626 for some discussion. | ||
| # Unfortunately, while the issue was closed, the `is_relative` function | ||
| # mentioned was never added. |
Member
There was a problem hiding this comment.
Looks like in 3.13+ we can use this! python/cpython#113829 but for now this seems sensible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is equivalent to orderly2's orderly_shared_resource. It looks for files in the
shareddirectory, at the root of the repository. Files and directories are copied to the packet directory, and recorded in the metadata.