Allow class names to begin with an underscore in textModel.ts #49652
Merged
alexdima merged 1 commit intomicrosoft:masterfrom May 15, 2018
Merged
Allow class names to begin with an underscore in textModel.ts #49652alexdima merged 1 commit intomicrosoft:masterfrom
alexdima merged 1 commit intomicrosoft:masterfrom
Conversation
Member
|
👍 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per microsoft/monaco-editor#869 class names that begin with an underscore are being cleaned of the underscore even though it is a valid identifier.
This stops underscores being cleaned, which allows WebPack generated css classnames to be used as decorations.