Adopt CodeAction type for built-in css server#310055
Merged
aeschli merged 2 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
Conversation
Remove the now-dead `_css.applyCodeAction` command handler and its activation event. The CSS server already returns proper `CodeAction` objects with `edit` via `doCodeActions2`, so the legacy command-based fallback is no longer reached. Fixes microsoft#237858
aeschli
previously approved these changes
Apr 15, 2026
Contributor
|
Thanks @yogeshwaran-c , nice change. |
dmitrivMS
approved these changes
Apr 15, 2026
dmitrivMS
approved these changes
Apr 15, 2026
alexr00
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The CSS language server already returns proper
CodeActionobjects (withedit) viadoCodeActions2(seeextensions/css-language-features/server/src/cssServer.ts). The client, however, still registered a legacy_css.applyCodeActioncommand that was used by the olderCommand-style code actions and is no longer invoked from the server.This PR removes the now-dead client-side glue:
_css.applyCodeActioncommand registration and itsapplyCodeActionhelper inextensions/css-language-features/client/src/cssClient.ts.commandsandwindowimports that were only used by that helper.onCommand:_css.applyCodeActionactivation event inextensions/css-language-features/package.jsonso the extension no longer activates on a command nobody fires.No behavior change is expected: code actions continue to flow through the standard
CodeAction.editpath that the editor applies directly.Fixes #237858