close
Skip to content

Increase control width to avoid truncating text#13

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
bhank:fix-dialog-text-width
Oct 17, 2019
Merged

Increase control width to avoid truncating text#13
joaomoreno merged 1 commit intomicrosoft:masterfrom
bhank:fix-dialog-text-width

Conversation

@bhank
Copy link
Copy Markdown
Contributor

@bhank bhank commented Oct 16, 2019

The text change in 887301d from "Updating VS Code..." to "Updating Visual Studio Code..." made it wide enough to be truncated and only show "Updating Visual".

This PR gives the text control the same width as the progress bar. It should fix microsoft/vscode#81433 .

I have only tested it in a resource editor, and not by actually building and running the updater.

@joaomoreno
Copy link
Copy Markdown
Member

Oh that's what that was! Great fix, thanks!

@joaomoreno joaomoreno self-assigned this Oct 17, 2019
@joaomoreno joaomoreno merged commit 0f17bfa into microsoft:master Oct 17, 2019
@joaomoreno joaomoreno added this to the October milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating dialog on Windows text is clipped

2 participants