Set the cloudtest session timeout to 4 hours#40291
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to extend CloudTest session lifetime to avoid test sessions timing out during longer runs.
Changes:
- Adds
sessionTimeoutto the CloudTest pipeline job template. - Adds a 24-hour sleep inside an existing Windows unit test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/windows/UnitTests.cpp |
Introduces a sleep_for(std::chrono::days(1)) in a unit test (causes test run to hang). |
.pipelines/test-job.yml |
Adds sessionTimeout setting for CloudTestServerBuildTask@2. |
|
|
||
| std::this_thread::sleep_for(std::chrono::days(1)); |
There was a problem hiding this comment.
std::this_thread::sleep_for(std::chrono::days(1)) will cause this unit test to hang for 24 hours, effectively blocking the entire test run/CI. If the intent is to extend CloudTest session lifetime, this should not be done inside a test case—remove this sleep and adjust the pipeline/session timeout configuration instead.
| std::this_thread::sleep_for(std::chrono::days(1)); |
| pipelineArtifactBuildUrl: '$(System.TaskDefinitionsUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)' | ||
| buildDropArtifactName: "" | ||
| timeoutInMinutes: 360 | ||
| sessionTimeout: 360 |
There was a problem hiding this comment.
The PR title indicates a 4 hour CloudTest session timeout, but sessionTimeout is set to 360 (which matches the other *InMinutes values here and would be 6 hours if interpreted as minutes). Please confirm the units expected by CloudTestServerBuildTask@2 and adjust the value to match the intended 4 hour timeout (and keep it consistent with the job/task timeoutInMinutes).
|
Why does it need to be so long? The tests run in 30 minutes or so for wsl1 and 1.5 hours for wsl2 |
That's because the watchdog timeout kicks in after 3 hours. I'm counting one hour to capture the dump and upload them to be safe |
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed