Set guest voume driver as default#40277
Merged
kvega005 merged 19 commits intomicrosoft:feature/wsl-for-appsfrom Apr 24, 2026
Merged
Set guest voume driver as default#40277kvega005 merged 19 commits intomicrosoft:feature/wsl-for-appsfrom
guest voume driver as default#40277kvega005 merged 19 commits intomicrosoft:feature/wsl-for-appsfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
…kevinve/defaultVolumeDriver
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes WSLC volume creation semantics so that the guest volume driver becomes the default when --driver is omitted, and updates end-to-end tests and CLI help expectations to match.
Changes:
- Default the service-side volume driver to
guestwhen no driver is specified. - Update CLI argument description/help text to show
guestas the default driver. - Update WSLC E2E tests to stop passing VHD-specific options by default and to validate
guestas the default driver.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCE2EVolumeRemoveTests.cpp | Updates volume-create invocations to rely on the new default driver. |
| test/windows/wslc/e2e/WSLCE2EVolumeListTests.cpp | Updates list tests to create volumes without VHD-specific options. |
| test/windows/wslc/e2e/WSLCE2EVolumeInspectTests.cpp | Updates inspect assertions to expect guest as the default driver. |
| test/windows/wslc/e2e/WSLCE2EVolumeCreateTests.cpp | Updates default-driver test and help-text expectation; removes VHD opts from default-path tests. |
| test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp | Updates named-volume test setup to create volumes without VHD-specific options. |
| src/windows/wslcsession/WSLCSession.cpp | Changes the service default driver from vhd to guest when not specified. |
| src/windows/wslc/arguments/ArgumentDefinitions.h | Updates CLI --driver argument description to show default guest. |
…/kvega005/WSL into user/kevinve/defaultVolumeDriver
OneBlue
approved these changes
Apr 23, 2026
Collaborator
OneBlue
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge after resolving conflicts
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/windows/wslc/e2e/WSLCE2EVolumeRemoveTests.cpp:69
- This test previously exercised
volume removeagainst volumes created using the vhd flow (via SizeBytes opts). With the default now "guest", it no longer validates thatvolume removestill correctly deletes vhd-backed volumes (including any vhd-specific cleanup paths). Consider keeping at least one remove scenario that creates a vhd volume explicitly (--driver vhdwith required opts) and then removes it.
WSLC_TEST_METHOD(WSLCE2E_Volume_Remove_Valid)
{
auto result = RunWslc(std::format(L"volume create {}", TestVolumeName));
result.Verify({.Stderr = L"", .ExitCode = 0});
VerifyVolumeIsListed(TestVolumeName);
result = RunWslc(std::format(L"volume remove {}", TestVolumeName));
result.Verify({.Stdout = std::format(L"{}\r\n", TestVolumeName), .Stderr = L"", .ExitCode = 0});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Set
guestvolume driver as the default option. Clean up code and update tests to reflect these changes.PR Checklist
Detailed Description of the Pull Request / Additional comments
The changes include adding a "guest" volume driver alongside the existing options, cleaning up the code, and updating the allow list. Tests have been modified to ensure they correctly validate the new default driver.
Validation Steps Performed
Validated the changes by running existing tests, which all passed successfully. Manual testing confirmed that the "guest" driver functions as expected.