Fix SIM103 lint error in issue_comment_bot.py - #13143
Merged
mekarpeles merged 1 commit intoJul 10, 2026
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
should_label_issue()inscripts/gh_scripts/issue_comment_bot.py(added in #13139) trips ruff'sSIM103:Because pre-commit.ci lints the whole repo (
--all-files), this failure surfaces on every open PR, not just #13139. The fix isn't auto-applicable (it's a ruff "unsafe" fix), so pre-commit.ci can't self-heal it.Fix
Collapse the
if ...: return False / return Trueinto a single negated return. No behavior change.ruff checkpasses clean.