Update Neousys available configs detection#1744
Conversation
The modification ensures that the Neousys interface's method '_detect_available_configs' function checks if NEOUSYS_CANLIB is None. If it's None, no configuration is returned, and if it's not, the usual configuration with the interface as 'neousys' and channel as 0 is returned. This provides an additional layer of error handling.
|
The change above will stop the Unfortunately, the detection does not query the hardware for an available channel. However, if someone does construct a python-can/can/interfaces/neousys/neousys.py Lines 170 to 176 in d40915c python-can/can/interfaces/neousys/neousys.py Lines 178 to 179 in d40915c @zariiii9003 Would you like a deeper dive into this topic or is 4e2bb4b an adequate fix to #1738? |
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, It's still a draft, can i merge?
Removed draft indication. Yes, I think merging is appropriate. |
The modification ensures that the Neousys interface's method '_detect_available_configs' function checks if NEOUSYS_CANLIB is None. If it's None, no configuration is returned, and if it's not, the usual configuration with the interface as 'neousys' and channel as 0 is returned. This provides an additional layer of error handling.
closes #1738