close
Skip to content

Avoid noisy SSH signing failures during push#1017

Open
pfleidi wants to merge 12 commits intomainfrom
fix/1password-commit-signing
Open

Avoid noisy SSH signing failures during push#1017
pfleidi wants to merge 12 commits intomainfrom
fix/1password-commit-signing

Conversation

@pfleidi
Copy link
Copy Markdown
Contributor

@pfleidi pfleidi commented Apr 24, 2026

https://entire.io/gh/entireio/cli/trails/f00e8cc8686b

What

This PR narrows the object signer behavior to avoid noisy commit-signing failures during git push when Git is configured to use a custom SSH signing program that go-git cannot invoke.

How

  • detect custom gpg.ssh.program values from system and global raw Git config before merge
  • skip native SSH signing when that custom SSH signer is configured
  • keep the change scoped to the existing system/global config behavior
  • add focused tests for raw-config detection and scope precedence

Notes

This PR does not change repo-local signer configuration behavior.

pfleidi added 8 commits April 23, 2026 15:29
Entire-Checkpoint: adedfe0c0274
Entire-Checkpoint: c4c4159e4769
Entire-Checkpoint: ed6b34baaab3
Entire-Checkpoint: 04a310e6daba
Entire-Checkpoint: bbffa529924f
Entire-Checkpoint: de7d8853de9e
Entire-Checkpoint: 63152c51a348
Copilot AI review requested due to automatic review settings April 24, 2026 01:34
@pfleidi pfleidi requested a review from a team as a code owner April 24, 2026 01:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Entire CLI’s go-git object signer configuration resolution so checkpoint commit signing respects repo-local Git signing settings (notably gpg.ssh.program) while keeping signing best-effort when higher-scope config can’t be read.

Changes:

  • Load and merge repo-local Git config alongside system/global scopes for signer setup.
  • Detect custom SSH signing programs via scoped raw configs (pre-merge) and skip native SSH signing when appropriate.
  • Expand unit tests around config precedence, raw-config merge behavior, and upper-scope load failure fallback.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
cmd/entire/cli/strategy/manual_commit_condensation.go Removes an ireturn nolint on an interface-returning helper.
cmd/entire/cli/objectsigner.go Adds repo-local config loading + effective gpg.ssh.program resolution to decide whether to use native SSH signing.
cmd/entire/cli/objectsigner_test.go Adds regression coverage for precedence/merge behavior and local custom SSH signer handling.

Comment thread cmd/entire/cli/objectsigner.go Outdated
Comment thread cmd/entire/cli/objectsigner_test.go Outdated
Entire-Checkpoint: 5fa7c13691bd
@pfleidi
Copy link
Copy Markdown
Contributor Author

pfleidi commented Apr 24, 2026

Bugbot run

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread cmd/entire/cli/objectsigner.go
Comment thread cmd/entire/cli/objectsigner.go Outdated
Comment thread cmd/entire/cli/objectsigner_test.go Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 4c75c4f. Configure here.

@pfleidi pfleidi changed the title Respect local git signer config for SSH signing Avoid noisy SSH signing failures during push Apr 24, 2026
pfleidi added 2 commits April 23, 2026 19:05
Entire-Checkpoint: 72f163990e95
Entire-Checkpoint: 108eb45f746f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants