Open
Conversation
Entire-Checkpoint: adedfe0c0274
Entire-Checkpoint: c4c4159e4769
Entire-Checkpoint: ed6b34baaab3
Entire-Checkpoint: 04a310e6daba
Entire-Checkpoint: bbffa529924f
Entire-Checkpoint: de7d8853de9e
Entire-Checkpoint: bc0486984183
Entire-Checkpoint: 63152c51a348
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Entire CLI’s go-git object signer configuration resolution so checkpoint commit signing respects repo-local Git signing settings (notably gpg.ssh.program) while keeping signing best-effort when higher-scope config can’t be read.
Changes:
- Load and merge repo-local Git config alongside system/global scopes for signer setup.
- Detect custom SSH signing programs via scoped raw configs (pre-merge) and skip native SSH signing when appropriate.
- Expand unit tests around config precedence, raw-config merge behavior, and upper-scope load failure fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/entire/cli/strategy/manual_commit_condensation.go | Removes an ireturn nolint on an interface-returning helper. |
| cmd/entire/cli/objectsigner.go | Adds repo-local config loading + effective gpg.ssh.program resolution to decide whether to use native SSH signing. |
| cmd/entire/cli/objectsigner_test.go | Adds regression coverage for precedence/merge behavior and local custom SSH signer handling. |
Entire-Checkpoint: 5fa7c13691bd
Contributor
Author
|
Bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4c75c4f. Configure here.
Entire-Checkpoint: 72f163990e95
Entire-Checkpoint: 108eb45f746f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/f00e8cc8686b
What
This PR narrows the object signer behavior to avoid noisy commit-signing failures during git push when Git is configured to use a custom SSH signing program that go-git cannot invoke.
How
gpg.ssh.programvalues from system and global raw Git config before mergeNotes
This PR does not change repo-local signer configuration behavior.