[docs] Minor updates from copilot review in the dotnet/docs-mobile repository.#25191
[docs] Minor updates from copilot review in the dotnet/docs-mobile repository.#25191rolfbjarne wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Documentation cleanup in the build docs (from the referenced docs-mobile PR) to improve readability and correct dotnet run --device formatting.
Changes:
- Normalized the
Runtarget text and updated the example-p:Device=...usage. - Fixed the
Deviceproperty description to correctly showdotnet run --device <Device>in a single inline code span.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/building-apps/build-targets.md | Updates the Run target wording and the Device property usage example. |
| docs/building-apps/build-properties.md | Fixes the Device property description formatting and terminology. |
|
|
||
| ```dotnetcli | ||
| dotnet build -t:Run project.csproj -p:Device=$(MY_DEVICE_UDID) | ||
| dotnet build -t:Run project.csproj -p:Device=<udid> |
There was a problem hiding this comment.
In the command example, using <udid> as a placeholder is problematic because <...> has shell meaning (input redirection) and copy/paste will fail. Prefer a safe placeholder (for example UDID, $UDID, or a concrete example value like 00001111-012301230123ABCD).
| dotnet build -t:Run project.csproj -p:Device=<udid> | |
| dotnet build -t:Run project.csproj -p:Device=UDID |
✅ [CI Build #b261621] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #b261621] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #b261621] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #b261621] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Ref: dotnet/docs-mobile#110