test(path): run path tests in node and bun#7104
Open
kt3k wants to merge 1 commit intodenoland:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7104 +/- ##
=======================================
Coverage 94.60% 94.61%
=======================================
Files 633 633
Lines 51777 51777
Branches 9324 9324
=======================================
+ Hits 48986 48987 +1
Misses 2216 2216
+ Partials 575 574 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
commented
Apr 24, 2026
| const url = new URL("file:///"); | ||
| url.pathname = encodeWhitespace( | ||
| path.replace(/%/g, "%25").replace(/\\/g, "%5C"), | ||
| path.replace(/^\/+/, "/").replace(/%/g, "%25").replace(/\\/g, "%5C"), |
Contributor
Author
There was a problem hiding this comment.
The below works differently in Deno and Node:
const u = new URL("file:///");
u.pathname = "//foo";
console.log(u.href);
// prints file:///foo in Deno
// prints file:////foo in Node, Bun, and browsersThis change normalizes the differences above (and therefore no breaking changes to deno users)
Contributor
Author
There was a problem hiding this comment.
Created an issue in rust-url about the above behavior servo/rust-url#1118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests of
pathin Node and Bunref #7103