fix: only show executable in ExecError.__str__, not full command line#2336
Merged
benhoyt merged 1 commit intocanonical:mainfrom Feb 22, 2026
Merged
fix: only show executable in ExecError.__str__, not full command line#2336benhoyt merged 1 commit intocanonical:mainfrom
benhoyt merged 1 commit intocanonical:mainfrom
Conversation
tonyandrewmeyer
approved these changes
Feb 20, 2026
Collaborator
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
Thanks for handling this! Agreed that it's better to lose a little debugging info in exchange for helping people avoid foot-guns.
dimaqq
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid credentials or sensitive data passed in command line args showing up in exception messages and logs. Sensitive data shouldn't be passed in command line args, but it sometimes is, so better to be cautious here. We do something similar with tracing: only send the executable name for pebble exec.