test: set SCENARIO_BARE_CHARM_ERRORS=true in Ops tests that care#2314
Merged
dimaqq merged 3 commits intocanonical:mainfrom Feb 18, 2026
Merged
test: set SCENARIO_BARE_CHARM_ERRORS=true in Ops tests that care#2314dimaqq merged 3 commits intocanonical:mainfrom
dimaqq merged 3 commits intocanonical:mainfrom
Conversation
james-garner-canonical
approved these changes
Feb 10, 2026
Contributor
james-garner-canonical
left a comment
There was a problem hiding this comment.
I'm happy with things being fixed this way. Arguably it would be nicer to use true instead, to avoid needing to assert on __cause__, and perhaps be a bit more future looking, but I'm fine with either way.
Collaborator
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
My preference would be that we did this but used true and adjusted the test as necessary. Long term we want that to be the default behaviour so it seems more logical to head in that direction.
tonyandrewmeyer
approved these changes
Feb 17, 2026
Collaborator
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
It's a noisier diff, but I think it's definitely better this way around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2298 using option 1