Merged
Conversation
tonyandrewmeyer
commented
Nov 13, 2025
james-garner-canonical
approved these changes
Nov 13, 2025
james-garner-canonical
approved these changes
Nov 13, 2025
Collaborator
|
Ah, thanks for this. Yeah, I noticed this over in Jubilant-land too. It's another thing that makes me wonder about the worthwhileness of spelling checks. But we can get David's opinion on all that when he's back. |
dimaqq
approved these changes
Nov 14, 2025
Contributor
|
Thanks for doing this @tonyandrewmeyer. The extra spelling exceptions were needed because the spelling check previously wasn't checking all text. I was tracking the fix in canonical/documentation-style-guide#138 (sorry, I think I forgot to mention that in my notes before I went away). I don't expect major changes to the spelling setup from now on, now that (as far as I could test previously) it's checking everything that it should be checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs spellcheck seems to have updated underneath us, so make adjustments so that the checks pass again.
For the most part, I've added words to the custom word list, but I've made a few adjustments to the docs in cases where it seemed better than adding the word.
The PR also corrects the description of Scenario's behaviour when creating a temporary charm root: only the metadata files are written - the
srcandlibfolders are not also copied there.(See also canonical/jubilant#225)