close
Skip to content

Submit pull request reviews using GitHub's "Review changes" button #7

Description

@cbeams

When reviewing a pull request, do not just add a normal comment, but actually click the "Review changes" button and add your summary using the ACK / NACK language at #6.

This makes it easier for everyone to see that a review has already been submitted for a given pull request without having to scroll through comments, makes it possible to search for pull requests without reviews, pull requests reviewed by a certain user, etc. It also makes the review comment itself that much more prominent, because it shows up with a big green checkmark, red X.

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions