MAST: New Catalogs module using VO-TAP#3582
Draft
snbianco wants to merge 17 commits intoastropy:mainfrom
Draft
Conversation
d6dfa92 to
6a8e22d
Compare
Updating docstrings, clarity
TAP URL constant, add comments Updating docstrings, don't set `available_collections` in method
Minor refactoring, more comments style Update default catalogs mapping name copilot comments Fixing collection names Update docstrings to be more explicit about region types fix style Add TODO about sky region classes
addressing comments from Sam uncommenting out line adjusting to new naming convention addressing more comments Starting off non-remote testing More test examples Style fixes to test_mast_remote Notes for non-remote tests
Adjusting from rebase Clear cache in non-remote tests
Catch up rebase
do not call network for default initializations of Catalogs
Avoid overflow errors updating tap_collections.json slight adjustments to parsing logic catalog tests typo correction addressing comments Some rebase fixes Rebase fix
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
+ Coverage 73.22% 73.76% +0.53%
==========================================
Files 226 227 +1
Lines 21000 21479 +479
==========================================
+ Hits 15378 15844 +466
- Misses 5622 5635 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com> More doc fixes Co-authored-by: Copilot <copilot@github.com> Typos Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor and modernization of the
Catalogsinterface in the MAST module, focusing on switching from the portal and catalogs.mast to VO-TAP. This interface has unified query workflows and enhanced discovery and filtering capabilities. It's a big one!For a quick rundown of the intended workflow, I recommend starting with the new documentation (
mast_catalog.rst).MAST Catalogs Interface Refactor and Enhancements:
Catalogsinterface is now centered around VO-TAP queries, replacing previous catalog-specific assumptions. It introduces new discovery helpers (get_collections,get_catalogs,get_column_metadata) and adds asupports_spatial_queriesmethod to check for positional-query support before querying.query_criteria,query_region,query_object) have been unified to support both positional and non-positional searches, with features such as cone and region searches, column selection, sorting, count-only queries, pagination (limit/offset), and advanced filtering.version,pagesize,page, and HSC-specific helpers, in favor of the new, more general interface.CatalogCollectionclass represents a collection of catalogs. TheCatalogsclass uses an internalCatalogCollectionobject in both the discovery and query methods.Testing and Documentation Updates:
tap_collections.json,tap_catalogs.vot,tap_columns.vot,tap_capabilities.xml, andtap_results.vot, supporting the new catalog interface.mast_catalog.rstis updated to reflect the new refactor.