Allow SampleResult#setEndTime be set in JSR223Sampler#5736
Closed
FSchumacher wants to merge 3 commits intoapache:masterfrom
Closed
Allow SampleResult#setEndTime be set in JSR223Sampler#5736FSchumacher wants to merge 3 commits intoapache:masterfrom
FSchumacher wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5733
Description
JSR223Sampler throws an exception, when the sampler has set the endTime of the sampleResult.
Motivation and Context
JSR223Sampler is often used to create results in a freestyle mode. So setting the endTime of a SampleResult should be allowed.
How Has This Been Tested?
Added a new Test class, that tests both paths setting and not setting the endTime on the SampleResult.
Screenshots (if appropriate):
Types of changes
It is a bit hard to decide on this. I think of it as a bug fix.
Checklist: