close
Skip to content

Allow SampleResult#setEndTime be set in JSR223Sampler#5736

Closed
FSchumacher wants to merge 3 commits intoapache:masterfrom
FSchumacher:allow-set-end-time-in-jsr223-sampler
Closed

Allow SampleResult#setEndTime be set in JSR223Sampler#5736
FSchumacher wants to merge 3 commits intoapache:masterfrom
FSchumacher:allow-set-end-time-in-jsr223-sampler

Conversation

@FSchumacher
Copy link
Copy Markdown
Contributor

Issue #5733

Description

JSR223Sampler throws an exception, when the sampler has set the endTime of the sampleResult.

Motivation and Context

JSR223Sampler is often used to create results in a freestyle mode. So setting the endTime of a SampleResult should be allowed.

How Has This Been Tested?

Added a new Test class, that tests both paths setting and not setting the endTime on the SampleResult.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

It is a bit hard to decide on this. I think of it as a bug fix.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@asfgit asfgit closed this in 2da0eb5 Nov 29, 2022
@FSchumacher FSchumacher deleted the allow-set-end-time-in-jsr223-sampler branch November 29, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant