Re-wrote some existing tests in Spock

[ham1]

Description

Re-wrote some existing tests in Spock:

• ThroughputControllerSpec
• MD5HexAssertionSpec
• RandomOrderControllerSpec
• org.apache.jmeter.engine.util.PackageSpec

plus some minor code tweaks.

How Has This Been Tested?

ant -Djava.awt.headless=true -Drmi_force_localhost=true -Dskip.bug52310=true -Dskip.test_https=true checkstyle clean test

Screenshots (if appropriate):

Types of changes

• Dev enhancement

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

[codecov-io]

Codecov Report

Merging #353 into trunk will decrease coverage by 0.09%.
The diff coverage is 93.78%.

@@            Coverage Diff             @@
##              trunk    #353     +/-   ##
==========================================
- Coverage     58.29%   58.2%   -0.1%     
+ Complexity    10242   10217     -25     
==========================================
  Files          1160    1160             
  Lines         74375   74205    -170     
  Branches       7334    7326      -8     
==========================================
- Hits          43357   43188    -169     
+ Misses        28519   28516      -3     
- Partials       2499    2501      +2

Impacted Files	Coverage Δ	Complexity Δ
...g/apache/jmeter/control/RandomOrderController.java	100% <ø> (ø)	4 <0> (ø)	⬇️
test/src/org/apache/jmeter/JMeterVersionTest.java	76.13% <0%> (-0.44%)	38 <0> (ø)
.../org/apache/jmeter/assertions/MD5HexAssertion.java	93.75% <100%> (ø)	9 <0> (ø)	⬇️
...rg/apache/jmeter/control/ThroughputController.java	66.66% <100%> (+1.66%)	29 <5> (+1)	⬆️
...he/jmeter/control/RandomOrderControllerSpec.groovy	100% <100%> (ø)	6 <6> (?)
...rg/apache/jmeter/engine/DistributedRunnerTest.java	87.77% <100%> (ø)	7 <0> (ø)	⬇️
...c/org/apache/jmeter/engine/util/PackageSpec.groovy	100% <100%> (ø)	5 <5> (?)
...pache/jmeter/assertions/MD5HexAssertionSpec.groovy	76.47% <76.47%> (ø)	5 <5> (?)
...che/jmeter/control/ThroughputControllerSpec.groovy	97.05% <97.05%> (ø)	8 <8> (?)
...mpler/hc/JMeterPoolingClientConnectionManager.java	27.77% <0%> (-3.18%)	10% <0%> (-1%)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520fb63...70844dc. Read the comment docs.