Open
Conversation
- Adds Javaluator library and wrapper - Adds configurable calculateExpression to calculate gross price per period from EPEX spot price and ancillary cost - Fallback to x + y as before if no expression is given
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3699 +/- ##
=============================================
+ Coverage 60.16% 60.19% +0.03%
Complexity 106 106
=============================================
Files 3234 3235 +1
Lines 141962 141977 +15
Branches 10446 10447 +1
=============================================
+ Hits 85404 85454 +50
+ Misses 53400 53356 -44
- Partials 3158 3167 +9 🚀 New features to boost your workflow:
|
Howaner
reviewed
Apr 24, 2026
| this.priceProvider.getMarketPrices().subscribe(this.onNewPrices); | ||
| this.priceProvider.getUpdateState().subscribe(this.onUpdateEvent); | ||
|
|
||
| this.priceCalculator = new PriceCalculator(config.calculateExpression()); |
Contributor
There was a problem hiding this comment.
We should make sure to throw an exception here if the expression is invalid.
WIthout that, the exception is thrown a lot of times at every price upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://community.openems.io/t/info-about-json-format-for-ancillary-costs-in-timeofusetarrif-entsoe/10261/15