close
Skip to content

ci(repo): trigger CI on ready_for_review#8467

Merged
jacekradko merged 1 commit intomainfrom
jacek/ci-ready-for-review
May 4, 2026
Merged

ci(repo): trigger CI on ready_for_review#8467
jacekradko merged 1 commit intomainfrom
jacek/ci-ready-for-review

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Summary

Draft-gated jobs in .github/workflows/ci.yml (build, tests, static analysis, dedupe/changeset) check github.event.pull_request.draft == false and skip when the PR is a draft. By default, pull_request only fires on opened, synchronize, and reopened — converting a draft PR to ready-for-review does not retrigger the workflow, so the gated jobs stay skipped until someone pushes a new commit.

Adding ready_for_review to pull_request.types makes CI re-evaluate when the PR exits draft, so all the gated jobs run without needing a no-op push.

Context

Hit on #8466 — PR was opened as draft, CI fired and skipped the heavy jobs, then the PR was marked ready-for-review and never re-ran CI.

Test plan

  • Open a draft PR; verify CI runs and skips the gated jobs as before
  • Convert the PR to ready-for-review; verify CI re-runs and the gated jobs now execute

Draft-gated jobs (build, tests, static analysis) skip when github.event.pull_request.draft is true. By default, pull_request only fires on opened/synchronize/reopened, so converting a draft PR to ready-for-review never re-runs CI and the gated jobs stay skipped. Adding ready_for_review to the trigger list ensures CI re-evaluates and the gated jobs run.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: d90da48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 4, 2026 6:01pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 605125dd-5d51-42a7-8741-e049daefa6d2

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and d90da48.

📒 Files selected for processing (2)
  • .changeset/ci-ready-for-review.md
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

This pull request adds configuration to the GitHub Actions CI workflow to restrict pull request event triggers to specific types: opened, synchronize, reopened, and ready_for_review. An empty changeset file is also created as part of the change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding the ready_for_review trigger to CI, which is exactly what the changeset accomplishes.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (draft-to-ready-for-review doesn't retrigger CI), the solution (adding ready_for_review to pull_request.types), and includes a test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 4, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8467

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8467

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8467

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8467

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8467

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8467

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8467

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8467

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8467

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8467

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8467

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8467

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8467

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8467

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8467

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8467

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8467

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8467

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8467

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8467

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8467

commit: d90da48

Copy link
Copy Markdown
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super helpful!

@jacekradko jacekradko merged commit 23c1432 into main May 4, 2026
43 checks passed
@jacekradko jacekradko deleted the jacek/ci-ready-for-review branch May 4, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants