Updating jira link to point to prow job#78575
Updating jira link to point to prow job#78575openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA periodic ROSA E2E test script adds logic to compute and export a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 42 minutes and 49 seconds.Comment |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-ad-staging-main |
|
@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml (1)
56-60: Normalize URL concatenation to avoid//in paths.The base value ends with
/and both branches prepend/, creating double slashes in the final URL. Usually tolerated, but easy to clean up.Suggested cleanup
- JOB_LINK="https://prow.ci.openshift.org/view/gs/test-platform-results/" + JOB_LINK="https://prow.ci.openshift.org/view/gs/test-platform-results"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml` around lines 56 - 60, The JOB_LINK concatenation can produce double slashes because the base JOB_LINK ends with '/' and the branches prepend '/' before paths; to fix, normalize before concatenation by stripping any trailing slash from JOB_LINK (use parameter expansion on JOB_LINK) or avoid leading slashes in the appended strings so the if/else branches build URLs without introducing '//' — update the branches that reference JOB_LINK, PULL_NUMBER, JOB_NAME, and BUILD_ID accordingly to use the normalized base.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 57-60: The subshell started with env -i clears all environment
variables so PULL_NUMBER, JOB_NAME and BUILD_ID are empty when constructing
JOB_LINK; modify the env -i invocation that launches bash so it explicitly
exports PULL_NUMBER, JOB_NAME and BUILD_ID into the sanitized environment (e.g.,
pass each as PULL_NUMBER="$PULL_NUMBER" JOB_NAME="$JOB_NAME"
BUILD_ID="$BUILD_ID" to env -i) so the conditional that references PULL_NUMBER,
JOB_NAME and BUILD_ID produces a correct JOB_LINK.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 56-60: The JOB_LINK concatenation can produce double slashes
because the base JOB_LINK ends with '/' and the branches prepend '/' before
paths; to fix, normalize before concatenation by stripping any trailing slash
from JOB_LINK (use parameter expansion on JOB_LINK) or avoid leading slashes in
the appended strings so the if/else branches build URLs without introducing '//'
— update the branches that reference JOB_LINK, PULL_NUMBER, JOB_NAME, and
BUILD_ID accordingly to use the normalized base.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7c4839d6-69b9-417a-a4a5-7ffbcc379bc5
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml
| if [ -n "${PULL_NUMBER:-}" ]; then | ||
| JOB_LINK="${JOB_LINK}/pr-logs/pull/openshift-online_rosa-e2e/${PULL_NUMBER}/${JOB_NAME}/${BUILD_ID}" | ||
| else | ||
| JOB_LINK="${JOB_LINK}/logs/${JOB_NAME}/${BUILD_ID}" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify env -i behavior for JOB_NAME/BUILD_ID/PULL_NUMBER.
set -euo pipefail
echo "Case 1: vars set in parent, then env -i without pass-through"
JOB_NAME=job BUILD_ID=123 PULL_NUMBER=456 \
env -i bash --norc --noprofile -c 'echo "JOB_NAME=${JOB_NAME:-<empty>} BUILD_ID=${BUILD_ID:-<empty>} PULL_NUMBER=${PULL_NUMBER:-<empty>}"'
echo "Case 2: vars explicitly passed through env -i"
JOB_NAME=job BUILD_ID=123 PULL_NUMBER=456 \
env -i JOB_NAME="${JOB_NAME:-}" BUILD_ID="${BUILD_ID:-}" PULL_NUMBER="${PULL_NUMBER:-}" \
bash --norc --noprofile -c 'echo "JOB_NAME=${JOB_NAME:-<empty>} BUILD_ID=${BUILD_ID:-<empty>} PULL_NUMBER=${PULL_NUMBER:-<empty>}"'Repository: openshift/release
Length of output: 276
🏁 Script executed:
cat ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml | head -80 | tail -35Repository: openshift/release
Length of output: 1347
🏁 Script executed:
rg 'JOB_NAME|BUILD_ID|PULL_NUMBER' --type yaml ci-operator/config/openshift-online/rosa-e2e/ | head -30Repository: openshift/release
Length of output: 508
🏁 Script executed:
rg 'env -i.*bash' ci-operator/config --type yaml -A 5 | grep -E '(PULL_NUMBER|JOB_NAME|BUILD_ID|env -i)' | head -40Repository: openshift/release
Length of output: 324
🏁 Script executed:
rg -i 'prow.*environment|JOB_NAME|BUILD_ID' --type md --type txt . 2>/dev/null | head -20Repository: openshift/release
Length of output: 1902
🏁 Script executed:
#!/bin/bash
# Detailed test of env -i variable passing
set -euo pipefail
echo "=== Test 1: env -i with inline assignment (as suggested in review) ==="
export JOB_NAME=myjob
export BUILD_ID=123
export PULL_NUMBER=456
env -i JOB_NAME="${JOB_NAME}" BUILD_ID="${BUILD_ID}" PULL_NUMBER="${PULL_NUMBER}" \
bash -c 'echo "JOB_NAME=$JOB_NAME BUILD_ID=$BUILD_ID PULL_NUMBER=$PULL_NUMBER"'
echo ""
echo "=== Test 2: Using env with multiple -u flags (alternative) ==="
env -i \
-u JOB_NAME -u BUILD_ID -u PULL_NUMBER \
bash -c 'echo "After -u flags: JOB_NAME=${JOB_NAME:-<empty>}"'
echo ""
echo "=== Test 3: Exporting before env -i ==="
export JOB_NAME=myjob
export BUILD_ID=123
export PULL_NUMBER=456
env -i bash -c 'echo "JOB_NAME=${JOB_NAME:-<empty>} BUILD_ID=${BUILD_ID:-<empty>} PULL_NUMBER=${PULL_NUMBER:-<empty>}"'
echo ""
echo "=== Test 4: Keep specific vars with env -i ==="
export JOB_NAME=myjob
export BUILD_ID=123
export PULL_NUMBER=456
env -i $(for var in JOB_NAME BUILD_ID PULL_NUMBER; do echo "$var=${!var}"; done) \
bash -c 'echo "JOB_NAME=$JOB_NAME BUILD_ID=$BUILD_ID PULL_NUMBER=$PULL_NUMBER"'Repository: openshift/release
Length of output: 460
Pass Prow environment variables through env -i to prevent malformed JOB_LINK.
Inside the env -i bash subshell (line 52), PULL_NUMBER, JOB_NAME, and BUILD_ID are unavailable because env -i clears the entire inherited environment. This causes the URL construction (lines 59–60) to expand empty variables, producing malformed links like .../logs//.
Pass these variables explicitly through env -i:
Fix
- env -i bash --norc --noprofile << 'EOF' > /tmp/podman.env
+ env -i \
+ JOB_NAME="${JOB_NAME}" \
+ BUILD_ID="${BUILD_ID}" \
+ PULL_NUMBER="${PULL_NUMBER:-}" \
+ bash --norc --noprofile << 'EOF' > /tmp/podman.env🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`
around lines 57 - 60, The subshell started with env -i clears all environment
variables so PULL_NUMBER, JOB_NAME and BUILD_ID are empty when constructing
JOB_LINK; modify the env -i invocation that launches bash so it explicitly
exports PULL_NUMBER, JOB_NAME and BUILD_ID into the sanitized environment (e.g.,
pass each as PULL_NUMBER="$PULL_NUMBER" JOB_NAME="$JOB_NAME"
BUILD_ID="$BUILD_ID" to env -i) so the conditional that references PULL_NUMBER,
JOB_NAME and BUILD_ID produces a correct JOB_LINK.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
/test generated-config |
|
@jfrazierRedHat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, jfrazierRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary by CodeRabbit