close
Skip to content

Add missing RBAC config for openstack-lightspeed registry access#78564

Open
malingatembo wants to merge 1 commit intoopenshift:mainfrom
malingatembo:add-openstack-lightspeed-RBAC
Open

Add missing RBAC config for openstack-lightspeed registry access#78564
malingatembo wants to merge 1 commit intoopenshift:mainfrom
malingatembo:add-openstack-lightspeed-RBAC

Conversation

@malingatembo
Copy link
Copy Markdown
Contributor

@malingatembo malingatembo commented Apr 29, 2026

This PR completes the setup initiated in #77611 by adding the necessary RBAC configuration for the openstack-lightspeed RAG image mirroring job.

According to the CI mirroring requirements [1], images promoted to a new namespace should create a folder in clusters/app.ci/registry-access with the name of the namespace, containing the manifests of the namespace and the RBAC regarding to that namespace. Provide an OWNERS file to allow your team to make changes to those manifests.

The files added in this PR should have been included in the PR #77611, but they were overlooked.

[1]
https://docs.ci.openshift.org/how-tos/mirroring-to-quay/#requirements

Summary by CodeRabbit

  • Chores
    • Configured new OpenStack Lightspeed registry namespace with role-based access controls, enabling image pull permissions for both authenticated and unauthenticated system groups
    • Established governance framework with designated approvers and reviewers for managing registry access configuration

This PR completes the setup initiated in openshift#77611 by adding the
necessary RBAC configuration for the openstack-lightspeed RAG
image mirroring job.

According to the CI mirroring requirements [1], images promoted
to a new namespace should create a folder in clusters/app.ci/registry-access
with the name of the namespace, containing the manifests of the
namespace and the RBAC regarding to that namespace. Provide an
OWNERS file to allow your team to make changes to those manifests.

The files added in this PR should have been included in the
PR openshift#77611, but they were overlooked.

[1]
https://docs.ci.openshift.org/how-tos/mirroring-to-quay/#requirements
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1ed9c628-cbb8-4afa-a9ca-9a249c7c6efe

📥 Commits

Reviewing files that changed from the base of the PR and between 3ae9d70 and 8587bb6.

📒 Files selected for processing (2)
  • clusters/app.ci/registry-access/openstack-lightspeed/OWNERS
  • clusters/app.ci/registry-access/openstack-lightspeed/admin_manifest.yaml

Walkthrough

Introduces a new openstack-lightspeed registry access configuration within the cluster CI infrastructure. Adds an OWNERS file specifying approvers and reviewers, along with a Kubernetes manifest defining the namespace and RBAC rules for image pulling permissions.

Changes

Cohort / File(s) Summary
OpenStack Lightspeed Registry Configuration
clusters/app.ci/registry-access/openstack-lightspeed/OWNERS, clusters/app.ci/registry-access/openstack-lightspeed/admin_manifest.yaml
Establishes ownership structure and creates new openstack-lightspeed Kubernetes namespace with RoleBinding to grant system:image-puller ClusterRole permissions to system groups for image pulling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding RBAC configuration for openstack-lightspeed registry access, which aligns with the PR's core purpose of creating namespace manifests and RBAC configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only YAML configuration files (OWNERS and admin_manifest.yaml), no Ginkgo test files present.
Test Structure And Quality ✅ Passed The pull request contains only YAML configuration files (OWNERS and manifest), no Ginkgo test code.
Microshift Test Compatibility ✅ Passed PR adds only RBAC configuration files, not Ginkgo e2e tests, so MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only configuration files (OWNERS and admin_manifest.yaml) with no Ginkgo e2e tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only namespace and RBAC configuration files for image registry access, containing no deployment manifests, operators, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR adds only static configuration files (OWNERS and admin_manifest.yaml) containing YAML data with no executable code or stdout writes that could corrupt OTE communication protocol.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not introduce any Ginkgo e2e tests, only configuration files (OWNERS and admin_manifest.yaml).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bear-redhat and pruan-rht April 29, 2026 15:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: malingatembo
Once this PR has been reviewed and has the lgtm label, please assign hector-vido for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@malingatembo: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@malingatembo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant