Add missing RBAC config for openstack-lightspeed registry access#78564
Add missing RBAC config for openstack-lightspeed registry access#78564malingatembo wants to merge 1 commit intoopenshift:mainfrom
Conversation
This PR completes the setup initiated in openshift#77611 by adding the necessary RBAC configuration for the openstack-lightspeed RAG image mirroring job. According to the CI mirroring requirements [1], images promoted to a new namespace should create a folder in clusters/app.ci/registry-access with the name of the namespace, containing the manifests of the namespace and the RBAC regarding to that namespace. Provide an OWNERS file to allow your team to make changes to those manifests. The files added in this PR should have been included in the PR openshift#77611, but they were overlooked. [1] https://docs.ci.openshift.org/how-tos/mirroring-to-quay/#requirements
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughIntroduces a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: malingatembo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@malingatembo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR completes the setup initiated in #77611 by adding the necessary RBAC configuration for the openstack-lightspeed RAG image mirroring job.
According to the CI mirroring requirements [1], images promoted to a new namespace should create a folder in clusters/app.ci/registry-access with the name of the namespace, containing the manifests of the namespace and the RBAC regarding to that namespace. Provide an OWNERS file to allow your team to make changes to those manifests.
The files added in this PR should have been included in the PR #77611, but they were overlooked.
[1]
https://docs.ci.openshift.org/how-tos/mirroring-to-quay/#requirements
Summary by CodeRabbit