lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array#62958
Open
Jah-yee wants to merge 1 commit intonodejs:mainfrom
Open
lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array#62958Jah-yee wants to merge 1 commit intonodejs:mainfrom
Jah-yee wants to merge 1 commit intonodejs:mainfrom
Conversation
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array. Fixes: nodejs#62952
Author
|
👋 Checking in — PR is a clean 1-line JSDoc type fix per WHATWG streams spec update. Happy to address any feedback or add tests. Thanks! 🙏 |
Author
|
PR still active and ready for review. 🙏 |
Member
|
Hi, thanks for the PR Please stop spamming, the maintainers will review it when they are free |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62958 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01%
==========================================
Files 706 706
Lines 219394 219394
Branches 42066 42066
==========================================
+ Hits 196674 196710 +36
+ Misses 14629 14584 -45
- Partials 8091 8100 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow WHATWG streams spec update: whatwg/streams#1367
ReadableStreamBYOBRequest.viewis always constructed as aUint8Array, and the specification will be updated to enforce this. This changes the documented return type fromArrayBufferViewtoUint8Array.Fix
Changed the JSDoc type annotation for
viewgetter from@type {ArrayBufferView}to@type {Uint8Array}inlib/internal/webstreams/readablestream.js.Fixes #62952