close
Skip to content

docs: document setBundleModuleLoader API#5900

Draft
killagu wants to merge 1 commit intonextfrom
agent/egg-dev/87c9b47a
Draft

docs: document setBundleModuleLoader API#5900
killagu wants to merge 1 commit intonextfrom
agent/egg-dev/87c9b47a

Conversation

@killagu
Copy link
Copy Markdown
Contributor

@killagu killagu commented Apr 26, 2026

Summary

  • Document setBundleModuleLoader(loader) in packages/utils/README.md
  • Note loader input normalization, undefined fallthrough behavior, default export compatibility, and clearing the loader
  • Add a short TypeScript usage example with importModule()

Validation

  • npm_config_store_dir=/tmp/pnpm-store pnpm dlx oxfmt packages/utils/README.md
  • npm_config_store_dir=/tmp/pnpm-store pnpm dlx oxfmt --check packages/utils/README.md
  • git diff --check

Note: pnpm install --frozen-lockfile --store-dir /tmp/pnpm-store was not used for full workspace validation because the current pnpm config does not match the checked-in lockfile (ERR_PNPM_LOCKFILE_CONFIG_MISMATCH). This PR is docs-only.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f5600b7d-17c1-48c9-862b-b21d482c00c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/egg-dev/87c9b47a

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying egg with  Cloudflare Pages  Cloudflare Pages

Latest commit: 31df76f
Status: ✅  Deploy successful!
Preview URL: https://17d93674.egg-cci.pages.dev
Branch Preview URL: https://agent-egg-dev-87c9b47a.egg-cci.pages.dev

View logs

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in packages/utils/README.md to include the setBundleModuleLoader function, which allows registering a custom module loader for bundled Egg applications. I have no feedback to provide.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying egg-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 31df76f
Status: ✅  Deploy successful!
Preview URL: https://1182e442.egg-v3.pages.dev
Branch Preview URL: https://agent-egg-dev-87c9b47a.egg-v3.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant