feat: fix bug in fast path#18
Merged
whtsky merged 1 commit intowhtsky:masterfrom Mar 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 97.77% 97.67% -0.11%
==========================================
Files 1 1
Lines 135 129 -6
==========================================
- Hits 132 126 -6
Misses 3 3
Continue to review full report at Codecov.
|
whtsky
requested changes
Mar 11, 2020
Before this bug fix, pixelmatch.py would report that the two new test images in this commit are identical. This is not the case, only a bit more than the upper quarter of the images are the same. The images were rendered by Chrome version 80.0.3987.132 running on Windows 7 and Windows 10 using the Segoe UI font. On the Windows 7 machine the font had been updated to be the same as on Windows 10 by following steps similar to the ones found here: https://www.quora.com/Is-it-possible-to-use-the-Windows-10-version-of-Segoe-UI-font-on-my-Windows-7-How Unfortunately pixelmatch is only able to identify about 61% of the pixels that differ between the two images as a result of antialiasing (23903 pixels out of 38893), but in this case 100% of the pixels that differ are due to antialiasing.
whtsky
approved these changes
Mar 12, 2020
Owner
whtsky
left a comment
There was a problem hiding this comment.
Thanks for your contirbution!
Since we already requires __len__ and __getitem__ to be implemented, IMO it's reasonable to require __eq__ to be implemented as well.
Owner
|
released in v0.1.1: https://pypi.org/project/pixelmatch/0.1.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try, this time with tests passing locally..