fix: don't round decimal unitless values for properties that accept them#5673
Merged
fix: don't round decimal unitless values for properties that accept them#5673
Conversation
Decimals like `line-height: 1.5` were being rounded to integers because the rounding logic in parseIntermediateOrInvalidValue applied to all `unit: "number"` values unconditionally. Now it only rounds when parseCssValue confirms the decimal is actually invalid for the property (e.g. z-index, column-count require integers; line-height does not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decimals like
line-height: 1.5were being rounded to integers because the rounding logic in parseIntermediateOrInvalidValue applied to allunit: "number"values unconditionally. Now it only rounds when parseCssValue confirms the decimal is actually invalid for the property (e.g. z-index, column-count require integers; line-height does not).