close
Skip to content

fix(cli): fix certain flags for webpack-cli serve#2722

Merged
hiroppy merged 1 commit intowebpack:v4from
knagaitsev:chore/update-serve-cli-flags
Aug 25, 2020
Merged

fix(cli): fix certain flags for webpack-cli serve#2722
hiroppy merged 1 commit intowebpack:v4from
knagaitsev:chore/update-serve-cli-flags

Conversation

@knagaitsev
Copy link
Copy Markdown
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Some adjustments are needed for certain flags to work as expected with webpack-cli serve.

This PR will rely on some fixes to how the webpack-cli arg parser works in here: webpack/webpack-cli#1649

Breaking Changes

N/A

Additional Info

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2020

Codecov Report

Merging #2722 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2722   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          37       37           
  Lines        1295     1295           
  Branches      345      345           
=======================================
  Hits         1203     1203           
  Misses         88       88           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289a98f...10b6634. Read the comment docs.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hiroppy

@hiroppy hiroppy changed the title chore(cli): fix certain flags for webpack-cli serve fix(cli): fix certain flags for webpack-cli serve Aug 25, 2020
@hiroppy hiroppy merged commit b45cdeb into webpack:v4 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants