fix(cli): fix certain flags for webpack-cli serve#2722
Merged
hiroppy merged 1 commit intowebpack:v4from Aug 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #2722 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 37 37
Lines 1295 1295
Branches 345 345
=======================================
Hits 1203 1203
Misses 88 88
Partials 4 4 Continue to review full report at Codecov.
|
hiroppy
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Some adjustments are needed for certain flags to work as expected with
webpack-cli serve.This PR will rely on some fixes to how the webpack-cli arg parser works in here: webpack/webpack-cli#1649
Breaking Changes
N/A
Additional Info