This repository was archived by the owner on May 16, 2025. It is now read-only.
create csv.py in renderers#480
Open
DvAu26 wants to merge 1 commit intovolatilityfoundation:masterfrom
Open
Conversation
That 's to have an output format like csv.
gleeda
suggested changes
Feb 20, 2018
| return "<FormatCellRenderer (" + repr(self._format_spec) + ")>" | ||
|
|
||
|
|
||
| class TextRenderer(Renderer): |
Member
There was a problem hiding this comment.
I would suggest is importing the TextRenderer() class instead of redefining it here.
Author
There was a problem hiding this comment.
I had made a pull request for commands.py too.
I just reuse the greptext rendere to make my csv rendere.
I think that it's possible to upgrade the greptext rendere too with : join "|" and not a +=
|
|
||
| __author__ = 'david' | ||
|
|
||
| class CellRenderer(object): |
Member
There was a problem hiding this comment.
Thank you for your pull request. One thing that I would ask, is that you import CellRenderer() and FormatCellRenderer() instead of redefining them
Author
There was a problem hiding this comment.
I have took the same def as render_greptext. So it's the same way for csv and greptext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That 's to have an output format like csv.
I discover GitHub...