Fix Dockerfile#139
Merged
Merged
Conversation
Since the tumblr team doesn't want to have the Dockerfile at / and Dockerfiles have no access to parent directories due to security reasons, we need to RUN git checkout instead of ADD.
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
Fix Dockerfile
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
Fix Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For security reasons, Dockerfiles have no access to parent directories, so we can't do ADD ../../ or something like that.
If having the Dockerfile in root is a no go for you, I can change it to do a git checkout in a RUN statement. Although it's better to use ADD because: