close
Skip to content

Hive Metastore Thrift protocol over HTTP(s) support with PT Tests#29191

Open
niteshy wants to merge 4 commits intotrinodb:masterfrom
niteshy:f-https-hms-tests
Open

Hive Metastore Thrift protocol over HTTP(s) support with PT Tests#29191
niteshy wants to merge 4 commits intotrinodb:masterfrom
niteshy:f-https-hms-tests

Conversation

@niteshy
Copy link
Copy Markdown

@niteshy niteshy commented Apr 22, 2026

Description

@kambhamvivekshankar PR has the actual code changes #29155.
This is the stacked commit on top of it #29155, with added PT tests for http & https

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions Bot added docs hive Hive connector labels Apr 22, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

2 similar comments
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@niteshy niteshy force-pushed the f-https-hms-tests branch from 1ac9150 to a825920 Compare April 22, 2026 18:43
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

kambhamvivekshankar and others added 4 commits April 22, 2026 15:11
In continuation to discussion in trinodb#25386, trying to restore Thrift over HTTP support for HMS.

This feature was initially introduced in trinodb#20371. Later removed in trinodb#25250 due to lack of CI tests.
Add launcher environments and a small suite so CI exercises the
HttpThriftMetastoreClient path against Hive4 HMS with Thrift over Http &
HTTPS.

- HTTPS: nginx TLS termination + coordinator truststore/JAVA_TOOL_OPTIONS
- Catalogs: http(s) metastore URIs, bearer rules, x-actor-username header
@niteshy niteshy force-pushed the f-https-hms-tests branch from a825920 to d64542d Compare April 22, 2026 22:11
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Apr 23, 2026

@niteshy We don't want to separate a PR into code changes and tests. Please coordinate with @kambhamvivekshankar

@kambhamvivekshankar
Copy link
Copy Markdown

Thanks @niteshy I will see what I can salvage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs hive Hive connector

Development

Successfully merging this pull request may close these issues.

3 participants