anthropic: preserve all parts in AI message serialization#1494
Open
anthropic: preserve all parts in AI message serialization#1494
Conversation
handleAIMessage only read msg.Parts[0], silently dropping subsequent tool calls when a response contained both text and one or more tool uses. This caused Anthropic to reject follow-up tool_result messages with 'tool_use block not found in previous message'. Iterate over all parts and emit a content block per part. Fixes tmc#1468.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleAIMessageinllms/anthropic/anthropicllm.goonly inspectedmsg.Parts[0]. When an assistant message contained both text and one or more tool calls (e.g.[TextContent, ToolCall]or[TextContent, ToolCall, ToolCall]for parallel tool use), every part after the first was silently dropped. The nexttool_resultmessage would then be rejected by Anthropic:This change iterates all parts and emits one Anthropic content block per part, mirroring the structure already used by
handleHumanMessage.Fixes #1468.
Test plan
go test ./llms/anthropic/...unit tests passgo vet ./llms/anthropic/...cleanTestHandleAIMessage_MultiplePartscovers text + multiple tool callsTestHandleAIMessage_Errorscovers empty parts and invalid tool arguments