close
Skip to content

Followup to rdar://29684330 to include expected-error comment.#7289

Merged
swift-ci merged 1 commit intoswiftlang:masterfrom
graydon:amend-rdar-29684330-with-comment-checking-actual-error
Feb 7, 2017
Merged

Followup to rdar://29684330 to include expected-error comment.#7289
swift-ci merged 1 commit intoswiftlang:masterfrom
graydon:amend-rdar-29684330-with-comment-checking-actual-error

Conversation

@graydon
Copy link
Copy Markdown
Contributor

@graydon graydon commented Feb 7, 2017

Address thinko in most recent PR #7088 wherein I left out an expected-error comment (and swift-ci let it through because it was an ios-only test, which isn't caught on smoke tests).

@graydon graydon requested a review from rudkx February 7, 2017 01:07
@graydon
Copy link
Copy Markdown
Contributor Author

graydon commented Feb 7, 2017

@switft-ci please test and merge

Copy link
Copy Markdown
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@graydon
Copy link
Copy Markdown
Contributor Author

graydon commented Feb 7, 2017

@swift-ci please test and merge

@swift-ci swift-ci merged commit 6694fd8 into swiftlang:master Feb 7, 2017
@graydon graydon deleted the amend-rdar-29684330-with-comment-checking-actual-error branch September 13, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants